Unit test resource (#44)

* Adding unit-test for resources * Addig csidriver tests * Adding status column * Adding status column * fix formatting issue * merge * Fixing unit-test * Fix driver-test
dell · Oct 15, 2024 · 810f0c5 · 810f0c5
1 parent 7ba8ac8
commit 810f0c5
Show file tree

Hide file tree

Showing 6 changed files with 296 additions and 1 deletion.
diff --git a/api/v1alpha1/csm_types.go b/api/v1alpha1/csm_types.go
@@ -52,6 +52,7 @@ type ContainerStorageModuleStatus struct {
 // +kubebuilder:printcolumn:name="CreationTime",type=date,JSONPath=`.metadata.creationTimestamp`
 // +kubebuilder:printcolumn:name="CSIDriverType",type=string,JSONPath=`.spec.driver.csiDriverType`,description="Type of CSIDriver"
 // +kubebuilder:printcolumn:name="ConfigVersion",type=string,JSONPath=`.spec.driver.configVersion`,description="Version of CSIDriver"
+// +kubebuilder:printcolumn:name="State",type=string,JSONPath=`.status.state`,description="State of Installation"
 //+kubebuilder:object:root=true
 //+kubebuilder:subresource:status
 

diff --git a/config/crd/bases/storage.dell.com_containerstoragemodules.yaml b/config/crd/bases/storage.dell.com_containerstoragemodules.yaml
@@ -30,6 +30,10 @@ spec:
       jsonPath: .spec.driver.configVersion
       name: ConfigVersion
       type: string
+    - description: State of Installation
+      jsonPath: .status.state
+      name: State
+      type: string
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/controllers/csm_controller_test.go b/controllers/csm_controller_test.go
@@ -2,6 +2,7 @@ package controllers
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"path/filepath"
 	"strings"
@@ -16,6 +17,9 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/suite"
 	appsv1 "k8s.io/api/apps/v1"
+	corev1 "k8s.io/api/core/v1"
+	rbacv1 "k8s.io/api/rbac/v1"
+	storagev1 "k8s.io/api/storage/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/kubernetes"
@@ -34,7 +38,22 @@ var (
 
 	unittestLogger = zap.New(zap.UseFlagOptions(&opts)).WithName("controllers").WithName("unit-test")
 
-	csmName = "csm"
+	createCMError  bool
+	getCMError     bool
+	updateCMError  bool
+	createCSIError bool
+	getCSIError    bool
+	updateCSIError bool
+	getCRError     bool
+	updateCRError  bool
+	createCRError  bool
+	getCRBError    bool
+	updateCRBError bool
+	createCRBError bool
+	createSAError  bool
+	getSAError     bool
+	updateSAError  bool
+	csmName        = "csm"
 )
 
 // CSMContrllerTestSuite implements testify suite
@@ -65,7 +84,13 @@ func (suite *CSMControllerTestSuite) SetupTest() {
 }
 
 func (suite *CSMControllerTestSuite) TestReconcile() {
+
 	suite.makeFakeCSM(csmName, suite.namespace)
+	suite.runFakeConfigManager(csmName, suite.namespace)
+	suite.runFakeCsiManager(csmName, suite.namespace)
+	suite.runFakeClusterroleManager(csmName, suite.namespace)
+	suite.runFakeClusterrolebindingManager(csmName, suite.namespace)
+	suite.runFakeServiceaccountManager(csmName, suite.namespace)
 	suite.runFakeCSMManager(csmName, suite.namespace, false)
 	suite.deleteCSM(context.Background(), csmName)
 	suite.runFakeCSMManager(csmName, suite.namespace, true)
@@ -135,6 +160,184 @@ func (suite *CSMControllerTestSuite) runFakeCSMManager(reqName, expectedErr stri
 		suite.handleDaemonsetTest(reconciler, "csm-node")
 		suite.handleDeploymentTest(reconciler, "csm-controller")
 	}
+
+	res, err = reconciler.Reconcile(context.Background(), req)
+	res, err = reconciler.Reconcile(context.Background(), req)
+}
+
+func (suite *CSMControllerTestSuite) runFakeConfigManager(reqName, expectedErr string) {
+	reconciler := suite.createReconciler()
+
+	req := reconcile.Request{
+		NamespacedName: types.NamespacedName{
+			Namespace: suite.namespace,
+			Name:      reqName,
+		},
+	}
+
+	// invoke controller Reconcile to test. Typically k8s would call this when resource is changed
+	res, err := reconciler.Reconcile(context.Background(), req)
+
+	ctrl.Log.Info("reconcile response", "res is: ", res)
+
+	if expectedErr == "" {
+		assert.NoError(suite.T(), err)
+	}
+
+	if err != nil {
+		ctrl.Log.Error(err, "Error returned")
+		assert.True(suite.T(), strings.Contains(err.Error(), expectedErr))
+	}
+
+	getCMError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	getCMError = false
+	createCMError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	createCMError = false
+	updateCMError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	updateCMError = false
+}
+
+func (suite *CSMControllerTestSuite) runFakeCsiManager(reqName, expectedErr string) {
+	reconciler := suite.createReconciler()
+
+	req := reconcile.Request{
+		NamespacedName: types.NamespacedName{
+			Namespace: suite.namespace,
+			Name:      reqName,
+		},
+	}
+
+	// invoke controller Reconcile to test. Typically k8s would call this when resource is changed
+	res, err := reconciler.Reconcile(context.Background(), req)
+
+	ctrl.Log.Info("reconcile response", "res is: ", res)
+
+	if expectedErr == "" {
+		assert.NoError(suite.T(), err)
+	}
+
+	if err != nil {
+		ctrl.Log.Error(err, "Error returned")
+		assert.True(suite.T(), strings.Contains(err.Error(), expectedErr))
+	}
+
+	getCSIError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	getCSIError = false
+	createCSIError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	createCSIError = false
+	updateCSIError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	updateCSIError = false
+}
+
+func (suite *CSMControllerTestSuite) runFakeClusterroleManager(reqName, expectedErr string) {
+	reconciler := suite.createReconciler()
+
+	req := reconcile.Request{
+		NamespacedName: types.NamespacedName{
+			Namespace: suite.namespace,
+			Name:      reqName,
+		},
+	}
+
+	// invoke controller Reconcile to test. Typically k8s would call this when resource is changed
+	res, err := reconciler.Reconcile(context.Background(), req)
+
+	ctrl.Log.Info("reconcile response", "res is: ", res)
+
+	if expectedErr == "" {
+		assert.NoError(suite.T(), err)
+	}
+
+	if err != nil {
+		ctrl.Log.Error(err, "Error returned")
+		assert.True(suite.T(), strings.Contains(err.Error(), expectedErr))
+	}
+
+	getCRError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	getCRError = false
+	createCRError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	createCRError = false
+	updateCRError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	updateCRError = false
+}
+
+func (suite *CSMControllerTestSuite) runFakeClusterrolebindingManager(reqName, expectedErr string) {
+	reconciler := suite.createReconciler()
+
+	req := reconcile.Request{
+		NamespacedName: types.NamespacedName{
+			Namespace: suite.namespace,
+			Name:      reqName,
+		},
+	}
+
+	// invoke controller Reconcile to test. Typically k8s would call this when resource is changed
+	res, err := reconciler.Reconcile(context.Background(), req)
+
+	ctrl.Log.Info("reconcile response", "res is: ", res)
+
+	if expectedErr == "" {
+		assert.NoError(suite.T(), err)
+	}
+
+	if err != nil {
+		ctrl.Log.Error(err, "Error returned")
+		assert.True(suite.T(), strings.Contains(err.Error(), expectedErr))
+	}
+
+	getCRBError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	getCRBError = false
+	createCRBError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	createCRBError = false
+	updateCRBError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	updateCRBError = false
+}
+
+func (suite *CSMControllerTestSuite) runFakeServiceaccountManager(reqName, expectedErr string) {
+	reconciler := suite.createReconciler()
+
+	req := reconcile.Request{
+		NamespacedName: types.NamespacedName{
+			Namespace: suite.namespace,
+			Name:      reqName,
+		},
+	}
+
+	// invoke controller Reconcile to test. Typically k8s would call this when resource is changed
+	res, err := reconciler.Reconcile(context.Background(), req)
+
+	ctrl.Log.Info("reconcile response", "res is: ", res)
+
+	if expectedErr == "" {
+		assert.NoError(suite.T(), err)
+	}
+
+	if err != nil {
+		ctrl.Log.Error(err, "Error returned")
+		assert.True(suite.T(), strings.Contains(err.Error(), expectedErr))
+	}
+
+	getSAError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	getSAError = false
+	createSAError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	createSAError = false
+	updateSAError = true
+	res, err = reconciler.Reconcile(context.Background(), req)
+	updateSAError = false
 }
 
 func (suite *CSMControllerTestSuite) handleDaemonsetTest(r *ContainerStorageModuleReconciler, name string) {
@@ -187,6 +390,74 @@ func (suite *CSMControllerTestSuite) makeFakeCSM(name, ns string) {
 
 func (suite *CSMControllerTestSuite) ShouldFail(method string, obj runtime.Object) error {
 	// Needs to implement based on need
+	switch v := obj.(type) {
+	case *corev1.ConfigMap:
+		cm := obj.(*corev1.ConfigMap)
+		if method == "Create" && createCMError {
+			fmt.Printf("[ShouldFail] force Configmap error for configmap named %+v\n", cm.Name)
+			fmt.Printf("[ShouldFail] force Configmap error for obj of type %+v\n", v)
+			return errors.New("unable to create ConfigMap")
+		} else if method == "Update" && updateCMError {
+			fmt.Printf("[ShouldFail] force update configmap error for obj of type %+v\n", v)
+			return errors.New("unable to update ConfigMap")
+		} else if method == "Get" && getCMError {
+			fmt.Printf("[ShouldFail] force get configmap error for obj of type %+v\n", v)
+			return errors.New("unable to get ConfigMap")
+		}
+	case *storagev1.CSIDriver:
+		csi := obj.(*storagev1.CSIDriver)
+		if method == "Create" && createCSIError {
+			fmt.Printf("[ShouldFail] force Csidriver error for csidriver named %+v\n", csi.Name)
+			fmt.Printf("[ShouldFail] force Csidriver error for obj of type %+v\n", v)
+			return errors.New("unable to create Csidriver")
+		} else if method == "Update" && updateCSIError {
+			fmt.Printf("[ShouldFail] force update Csidriver error for obj of type %+v\n", v)
+			return errors.New("unable to update Csidriver")
+		} else if method == "Get" && getCSIError {
+			fmt.Printf("[ShouldFail] force get Csidriver error for obj of type %+v\n", v)
+			return errors.New("unable to get Csidriver")
+		}
+	case *rbacv1.ClusterRole:
+		cr := obj.(*rbacv1.ClusterRole)
+		if method == "Create" && createCRError {
+			fmt.Printf("[ShouldFail] force ClusterRole error for ClusterRole named %+v\n", cr.Name)
+			fmt.Printf("[ShouldFail] force ClusterRole error for obj of type %+v\n", v)
+			return errors.New("unable to create ClusterRole")
+		} else if method == "Update" && updateCRError {
+			fmt.Printf("[ShouldFail] force update ClusterRole error for obj of type %+v\n", v)
+			return errors.New("unable to update ClusterRole")
+		} else if method == "Get" && getCRError {
+			fmt.Printf("[ShouldFail] force get ClusterRole error for obj of type %+v\n", v)
+			return errors.New("unable to get ClusterRole")
+		}
+	case *rbacv1.ClusterRoleBinding:
+		crb := obj.(*rbacv1.ClusterRoleBinding)
+		if method == "Create" && createCRBError {
+			fmt.Printf("[ShouldFail] force ClusterRoleBinding error for ClusterRoleBinding named %+v\n", crb.Name)
+			fmt.Printf("[ShouldFail] force ClusterRoleBinding error for obj of type %+v\n", v)
+			return errors.New("unable to create ClusterRoleBinding")
+		} else if method == "Update" && updateCRBError {
+			fmt.Printf("[ShouldFail] force update ClusterRoleBinding error for obj of type %+v\n", v)
+			return errors.New("unable to update ClusterRoleBinding")
+		} else if method == "Get" && getCRBError {
+			fmt.Printf("[ShouldFail] force get ClusterRoleBinding error for obj of type %+v\n", v)
+			return errors.New("unable to get ClusterRoleBinding")
+		}
+	case *corev1.ServiceAccount:
+		sa := obj.(*corev1.ServiceAccount)
+		if method == "Create" && createSAError {
+			fmt.Printf("[ShouldFail] force ServiceAccount error for ServiceAccount named %+v\n", sa.Name)
+			fmt.Printf("[ShouldFail] force ServiceAccount error for obj of type %+v\n", v)
+			return errors.New("unable to create ServiceAccount")
+		} else if method == "Update" && updateSAError {
+			fmt.Printf("[ShouldFail] force update ServiceAccount error for obj of type %+v\n", v)
+			return errors.New("unable to update ServiceAccount")
+		} else if method == "Get" && getSAError {
+			fmt.Printf("[ShouldFail] force get ServiceAccount error for obj of type %+v\n", v)
+			return errors.New("unable to get ServiceAccount")
+		}
+	default:
+	}
 	return nil
 }
 

diff --git a/deploy/crds/storage.dell.com_containerstoragemodules.yaml b/deploy/crds/storage.dell.com_containerstoragemodules.yaml
@@ -28,6 +28,10 @@ spec:
       jsonPath: .spec.driver.configVersion
       name: ConfigVersion
       type: string
+    - description: State of Installation
+      jsonPath: .status.state
+      name: State
+      type: string
     name: v1alpha1
     schema:
       openAPIV3Schema:

diff --git a/tests/config/driverconfig/badDriver/v2.1.0/driver-config-params.yaml b/tests/config/driverconfig/badDriver/v2.1.0/driver-config-params.yaml
@@ -2,3 +2,4 @@ this snfoiasga
  is
 
  843*&(*(% invalid YAml
+
diff --git a/tests/config/driverconfig/powerscale/v2.1.0/csidriver.yaml b/tests/config/driverconfig/powerscale/v2.1.0/csidriver.yaml
@@ -0,0 +1,14 @@
+apiVersion: storage.k8s.io/v1
+kind: CSIDriver
+metadata:
+    name: csi-isilon.dellemc.com
+    ownerReferences:
+    - apiVersion: cache.example.com/v1alpha1
+      kind: Memcached
+      name: example-memcached
+spec:
+    attachRequired: true
+    podInfoOnMount: true
+    volumeLifecycleModes:
+    - Persistent
+    - Ephemeral
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,3 +2,4 @@ this snfoiasga
		is

		843&((% invalid YAml