Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KRV-2816 : documentation in values.yaml toleration for running on master node incorrect #61

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

karthikk92
Copy link
Collaborator

@karthikk92 karthikk92 commented Feb 9, 2022

Description

documentation in values.yaml toleration for running on master node incorrect

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#216

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

master is tainted as shown bellow :
taint in master

  1. Installation of pod on master without toleration defined in myvalues.yaml and pods are not scheduled as expected :

without toleratiorn and only taint in master

and corresponding myvalues:

myvalues without toleratiorn and  taint in master

  1. Installation of pod on master with toleration defined in myvalues.yaml and pods are scheduled as expected:

with toleratiorn and  taint in master

  and corresponding myvalues:

myvalues withtoleratiorn and  taint in master

@karthikk92 karthikk92 merged commit 51d4750 into main Feb 10, 2022
@karthikk92 karthikk92 deleted the documentation_values_file branch February 10, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants