Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Documentation in values.yaml related to toleration for running on master node is incorrect - CSI driver for Unity-XT #216

Closed
karthikk92 opened this issue Mar 11, 2022 · 1 comment
Assignees
Labels
area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@karthikk92
Copy link

Bug Description

READ THIS IN "BLOCK QUOTE" STYLE.
In csi-unity/helm/values.yaml in the tolerations section comments, it uses a toleration of

#tolerations: Define tolerations for the controllers, if required.

Default value: None
tolerations:

  • key: "node-role.kubernetes.io/master"
    operator: "Equal"
    value: "true"
    effect: "NoSchedule"
    This will not successfully place the controller(s) on master nodes. It needs to be like in csi-powerflex and csi-powerstore:

tolerations: Define tolerations for the controllers, if required.
Leave as blank to install controller on worker nodes
Default value: None
tolerations:

  • key: "node-role.kubernetes.io/master"
    operator: "Exists"
    effect: "NoSchedule"

Logs

tolerations: Define tolerations for the controllers, if required.
Leave as blank to install controller on worker nodes
Default value: None
tolerations:

  • key: "node-role.kubernetes.io/master"
    operator: "Exists"
    effect: "NoSchedule"

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

documentation.

Expected Behavior

Default value: None
tolerations:

  • key: "node-role.kubernetes.io/master"
    operator: "Exists"
    effect: "NoSchedule"

CSM Driver(s)

CSI Driver for unity

Installation Type

No response

Container Storage Modules Enabled

No response

Container Orchestrator

Kubernetes 1.23.1

Operating System

RHEL 8

@karthikk92 karthikk92 added needs-triage Issue requires triage. type/bug Something isn't working. This is the default label associated with a bug issue. labels Mar 11, 2022
@karthikk92 karthikk92 self-assigned this Mar 11, 2022
@karthikk92 karthikk92 added area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity and removed needs-triage Issue requires triage. labels Mar 11, 2022
@karthikk92 karthikk92 added this to the v1.2.0 milestone Mar 11, 2022
@karthikk92
Copy link
Author

Fixed and merged

@gallacher gallacher changed the title [BUG]: documentation in values.yaml toleration for running on master node incorrect [BUG]: Documentation in values.yaml related to toleration for running on master node is incorrect - CSI driver for Unity-XT Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

1 participant