-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions And Monitoring Calls For Replication #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxan98
previously approved these changes
Feb 22, 2022
IliaRN
previously approved these changes
Feb 22, 2022
randeepdell
reviewed
Feb 23, 2022
randeepdell
reviewed
Feb 23, 2022
randeepdell
reviewed
Feb 23, 2022
randeepdell
reviewed
Feb 23, 2022
randeepdell
reviewed
Feb 23, 2022
randeepdell
reviewed
Feb 23, 2022
randeepdell
reviewed
Feb 23, 2022
bpjain2004
previously approved these changes
Feb 24, 2022
please update the goisilon's latest commit version in go.mod |
Yep, just done that |
IliaRN
approved these changes
Feb 24, 2022
bpjain2004
approved these changes
Feb 24, 2022
prablr79
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
replicationCertificateID
that should be set if you want to use SyncIQ encryptionThis PR should be merged after dell/gopowerscale#22 is merged and corresponding changes made to
go.mod
replace to point to main branchGitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
(Node tests were failing for me, but we haven't touched that part at all)
How Has This Been Tested?
This was tested multiple times using real k8s cluster and e2e test scenarios