Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions And Monitoring Calls For Replication #57

Merged
merged 24 commits into from
Feb 24, 2022
Merged

Conversation

walker2
Copy link
Contributor

@walker2 walker2 commented Feb 22, 2022

Description

  • Implementation of ExecuteAction and GetStorageProtectionGroupStatus calls
  • Use rockylinux instead of centos for dev builds
  • Use the latest csi extensions
  • Added a new optional field to secret.yaml replicationCertificateID that should be set if you want to use SyncIQ encryption
  • Added sample replication storageclass
  • Fixed failing replication tests

This PR should be merged after dell/gopowerscale#22 is merged and corresponding changes made to go.mod replace to point to main branch


GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#116

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
    (Node tests were failing for me, but we haven't touched that part at all)
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

This was tested multiple times using real k8s cluster and e2e test scenarios

maxan98
maxan98 previously approved these changes Feb 22, 2022
IliaRN
IliaRN previously approved these changes Feb 22, 2022
service/controller.go Outdated Show resolved Hide resolved
service/replication.go Outdated Show resolved Hide resolved
service/replication.go Outdated Show resolved Hide resolved
bpjain2004
bpjain2004 previously approved these changes Feb 24, 2022
@bpjain2004
Copy link
Collaborator

please update the goisilon's latest commit version in go.mod

@walker2
Copy link
Contributor Author

walker2 commented Feb 24, 2022

please update the goisilon's latest commit version in go.mod

Yep, just done that

@bpjain2004 bpjain2004 merged commit 2a3d70c into main Feb 24, 2022
@bpjain2004 bpjain2004 deleted the replication/actions branch February 24, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants