Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsgrouppolicy pscale #48

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Fsgrouppolicy pscale #48

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17a09fe
fsgrouppolicy support for csi-powerscale
nitesh3108 Jan 31, 2022
0798402
Resolved fomatting issues
nitesh3108 Jan 31, 2022
f48fb9f
comments addressed
nitesh3108 Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/csi-isilon/templates/csidriver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ metadata:
spec:
attachRequired: true
podInfoOnMount: true
fsGroupPolicy: {{ .Values.fsGroupPolicy }}
volumeLifecycleModes:
- Persistent
- Ephemeral
10 changes: 10 additions & 0 deletions helm/csi-isilon/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,16 @@ kubeletConfigDir: /var/lib/kubelet
# Default value: false
enableCustomTopology: false

# fsGroupPolicy: This is defined in Driver's spec. Supports three different mode which defines volume modification and ownership change upon mount operation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rephrase this sentence to: "Defines if the underlying volume supports changing ownership and permission of the volume before being mounted."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# Allowed values:
# ReadWriteOnceWithFSType: supports volume ownership and permissions change only if the fsType is defined
# and the volume's accessModes contains ReadWriteOnce
# File: kubernetes may use Kubernetes may use fsGroup to change permissions and ownership of the volume
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated "kubernetes may use", please correct

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

# to match user requested fsGroup in the pod's security policy regardless of fstype or access mode.
# None: volumes will be mounted with no modifications.
# Default value: ReadWriteOnceWithFSType
fsGroupPolicy: ReadWriteOnceWithFSType

# controller: configure controller pod specific parameters
controller:
# controllerCount: defines the number of csi-powerscale controller pods to deploy to
Expand Down