Fsgrouppolicy pscale #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitesh3108
requested review from
prablr79,
randeepdell,
Sakshi-dell and
shefali-malhotra
as code owners
bpjain2004
reviewed
Feb 1, 2022
helm/csi-isilon/values.yaml
Outdated
| @@ -59,6 +59,16 @@ kubeletConfigDir: /var/lib/kubelet | |||
| # Default value: false | |||
| enableCustomTopology: false | |||
|
|
|||
| # fsGroupPolicy: This is defined in Driver's spec. Supports three different mode which defines volume modification and ownership change upon mount operation. | |||
There was a problem hiding this comment.
Can you rephrase this sentence to: "Defines if the underlying volume supports changing ownership and permission of the volume before being mounted."
bpjain2004
reviewed
Feb 1, 2022
helm/csi-isilon/values.yaml
Outdated
| # Allowed values: | ||
| # ReadWriteOnceWithFSType: supports volume ownership and permissions change only if the fsType is defined | ||
| # and the volume's accessModes contains ReadWriteOnce | ||
| # File: kubernetes may use Kubernetes may use fsGroup to change permissions and ownership of the volume |
There was a problem hiding this comment.
Repeated "kubernetes may use", please correct
bpjain2004
approved these changes
Feb 1, 2022
randeepdell
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made fsGroupPolicy configurable for csi-powerscale
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration