CSM Replication Support For PowerScale #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IliaRN
requested review from
bpjain2004,
nitesh3108,
prablr79,
randeepdell,
Sakshi-dell and
shefali-malhotra
as code owners
IliaRN
force-pushed
the
feature/replication
branch
2 times, most recently
from
c85b1a7 to
5b537dc
Compare
|
Need to rebase properly so that this PR reflects only the changes intended to be made and not show changes that are already merged. |
bpjain2004
reviewed
Jan 28, 2022
# Conflicts: # go.mod # go.sum # service/controller.go # service/step_defs_test.go
IliaRN
force-pushed
the
feature/replication
branch
from
5b537dc to
b43b95c
Compare
walker2
approved these changes
Feb 1, 2022
bpjain2004
approved these changes
Feb 1, 2022
randeepdell
approved these changes
Feb 1, 2022
| }, | ||
| }, | ||
| }, | ||
| // { |
There was a problem hiding this comment.
Please add a note here or in PR description as to why this is commented so that anyone picking it up has a starting point.
There was a problem hiding this comment.
This part alongside supported actions will be uncommented in further PRs that will add support for actions execution and protection group monitoring. This PR does not implement those calls yet they just left as commented out for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with CSM Replication Support For PowerScale. Added initial replication code, implemented CreateRemoteVolume, CreateStorageProtectionGroup, DeleteStorageProtectionGroup methods, and BDD tests for new changes.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: