Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E FSGroup Test Fix #336

Merged
merged 3 commits into from
Oct 15, 2024
Merged

E2E FSGroup Test Fix #336

merged 3 commits into from
Oct 15, 2024

Conversation

rishabhatdell
Copy link
Contributor

Description

This PR fixes the failing e2efsgroup tests.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1521

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran e2e tests successfully
    image

donatwork
donatwork previously approved these changes Oct 14, 2024
View reviewed changes
test/e2e-fsgroup/README.md Outdated Show resolved Hide resolved
@adarsh-dell
Copy link
Contributor

@rishabhatdell Some of the checks are failing, Please fix them.
Thanks

@rishabhatdell rishabhatdell merged commit 2346d8a into main Oct 15, 2024
4 checks passed
@anandrajak1 anandrajak1 deleted the e2e-fsgroup-fix branch October 17, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@donatwork donatwork donatwork left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishabhatdell @adarsh-dell @donatwork @AkshaySainiDell