[ISSUE-1096] Fix lint and unit test error for resolution to atl-22498 #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Pavkovic <[email protected]>
eddiepavkovic
requested review from
libzhang,
lordjun,
safronovD,
prasant123,
katarzyna-kulpa and
Andrzej-Zukowski
- to fix unit test Signed-off-by: Eddie Pavkovic <[email protected]>
eddiepavkovic
changed the title
libzhang
reviewed
Feb 26, 2024
pkg/base/linuxutils/lsblk/lsblk.go
Outdated
| @@ -161,8 +161,13 @@ func (l *LSBLK) GetBlockDevices(device string) ([]BlockDevice, error) { | |||
| // Receives an instance of drivecrd.Drive struct | |||
| // Returns drive's path based on provided drivecrd.Drive or error if something went wrong | |||
| func (l *LSBLK) SearchDrivePath(drive *api.Drive) (string, error) { | |||
| // device path might be already set by hwmgr | |||
There was a problem hiding this comment.
adding this code back seems violate @prasant123 previous fix code intention. if device is in drive CR, then the device name in driveCR is returned here, this might be a wrong name due to device name change.
There was a problem hiding this comment.
ok i'll remove the test case and put back his orig code.
thanks
There was a problem hiding this comment.
@libzhang - do you have any idea why all the PR checks are no longer on this PR?
There was a problem hiding this comment.
I am not sure, maybe there is some bug in the our release branch workflow.
libzhang
reviewed
Feb 26, 2024
…t case Signed-off-by: Eddie Pavkovic <[email protected]>
libzhang
approved these changes
Feb 26, 2024
Andrzej-Zukowski
pushed a commit
that referenced
this pull request
Feb 26, 2024
…#1098) * [Issue #1096] - Fix lint error for bug atl-22498 Signed-off-by: Eddie Pavkovic <[email protected]> * [Issue #1096] - Put code back that returned device if path set - to fix unit test Signed-off-by: Eddie Pavkovic <[email protected]> * [ISSUE-1096] - Put back code from previous PR and removed invalid test case Signed-off-by: Eddie Pavkovic <[email protected]> --------- Signed-off-by: Eddie Pavkovic <[email protected]>
Andrzej-Zukowski
pushed a commit
that referenced
this pull request
Feb 26, 2024
…#1098) * [Issue #1096] - Fix lint error for bug atl-22498 Signed-off-by: Eddie Pavkovic <[email protected]> * [Issue #1096] - Put code back that returned device if path set - to fix unit test Signed-off-by: Eddie Pavkovic <[email protected]> * [ISSUE-1096] - Put back code from previous PR and removed invalid test case Signed-off-by: Eddie Pavkovic <[email protected]> --------- Signed-off-by: Eddie Pavkovic <[email protected]> Signed-off-by: Andrzej Zukowski <[email protected]>
Andrzej-Zukowski
added a commit
that referenced
this pull request
Feb 26, 2024
* [Issue-1084] Addjust scheduler extender algorithm Signed-off-by: Andrzej Zukowski <[email protected]> * [Issue-1084] Fixes after review Signed-off-by: Andrzej Zukowski <[email protected]> * [Issue-1091] 1.5.1 version (#1093) Signed-off-by: Andrzej Zukowski <[email protected]> * Finding drive vid in lsblk vendor (#1094) * Finding drive vid in lsblk vendor * addressing review comments * Initializing device --------- Signed-off-by: Andrzej Zukowski <[email protected]> * [ISSUE-1096] Fix lint and unit test error for resolution to atl-22498 (#1098) * [Issue #1096] - Fix lint error for bug atl-22498 Signed-off-by: Eddie Pavkovic <[email protected]> * [Issue #1096] - Put code back that returned device if path set - to fix unit test Signed-off-by: Eddie Pavkovic <[email protected]> * [ISSUE-1096] - Put back code from previous PR and removed invalid test case Signed-off-by: Eddie Pavkovic <[email protected]> --------- Signed-off-by: Eddie Pavkovic <[email protected]> Signed-off-by: Andrzej Zukowski <[email protected]> * [ISSUE-1096] Change component version to 1.6.0 Signed-off-by: Andrzej Zukowski <[email protected]> --------- Signed-off-by: Andrzej Zukowski <[email protected]> Signed-off-by: Eddie Pavkovic <[email protected]> Co-authored-by: PrasantDell <[email protected]> Co-authored-by: eddiepavkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #1096
Fixed lint issue from previous #1095 merge
PR checklist
Testing
https://asd-ecs-jenkins.isus.emc.com/job/csi-custom-build/1006/
Running csi-custom-ci and csi-custom-build