-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22498 - lint issue with previous fix for lsblk.go #1096
Labels
bug
Something isn't working
Comments
eddiepavkovic
added a commit
that referenced
this issue
Feb 26, 2024
Signed-off-by: Eddie Pavkovic <[email protected]>
This was referenced Feb 26, 2024
eddiepavkovic
added a commit
that referenced
this issue
Feb 26, 2024
- to fix unit test Signed-off-by: Eddie Pavkovic <[email protected]>
7 tasks
eddiepavkovic
added a commit
that referenced
this issue
Feb 26, 2024
…#1098) * [Issue #1096] - Fix lint error for bug atl-22498 Signed-off-by: Eddie Pavkovic <[email protected]> * [Issue #1096] - Put code back that returned device if path set - to fix unit test Signed-off-by: Eddie Pavkovic <[email protected]> * [ISSUE-1096] - Put back code from previous PR and removed invalid test case Signed-off-by: Eddie Pavkovic <[email protected]> --------- Signed-off-by: Eddie Pavkovic <[email protected]>
PR #1098 merged |
Andrzej-Zukowski
pushed a commit
that referenced
this issue
Feb 26, 2024
…#1098) * [Issue #1096] - Fix lint error for bug atl-22498 Signed-off-by: Eddie Pavkovic <[email protected]> * [Issue #1096] - Put code back that returned device if path set - to fix unit test Signed-off-by: Eddie Pavkovic <[email protected]> * [ISSUE-1096] - Put back code from previous PR and removed invalid test case Signed-off-by: Eddie Pavkovic <[email protected]> --------- Signed-off-by: Eddie Pavkovic <[email protected]>
Andrzej-Zukowski
pushed a commit
that referenced
this issue
Feb 26, 2024
…#1098) * [Issue #1096] - Fix lint error for bug atl-22498 Signed-off-by: Eddie Pavkovic <[email protected]> * [Issue #1096] - Put code back that returned device if path set - to fix unit test Signed-off-by: Eddie Pavkovic <[email protected]> * [ISSUE-1096] - Put back code from previous PR and removed invalid test case Signed-off-by: Eddie Pavkovic <[email protected]> --------- Signed-off-by: Eddie Pavkovic <[email protected]> Signed-off-by: Andrzej Zukowski <[email protected]>
Andrzej-Zukowski
added a commit
that referenced
this issue
Feb 26, 2024
* [Issue-1084] Addjust scheduler extender algorithm Signed-off-by: Andrzej Zukowski <[email protected]> * [Issue-1084] Fixes after review Signed-off-by: Andrzej Zukowski <[email protected]> * [Issue-1091] 1.5.1 version (#1093) Signed-off-by: Andrzej Zukowski <[email protected]> * Finding drive vid in lsblk vendor (#1094) * Finding drive vid in lsblk vendor * addressing review comments * Initializing device --------- Signed-off-by: Andrzej Zukowski <[email protected]> * [ISSUE-1096] Fix lint and unit test error for resolution to atl-22498 (#1098) * [Issue #1096] - Fix lint error for bug atl-22498 Signed-off-by: Eddie Pavkovic <[email protected]> * [Issue #1096] - Put code back that returned device if path set - to fix unit test Signed-off-by: Eddie Pavkovic <[email protected]> * [ISSUE-1096] - Put back code from previous PR and removed invalid test case Signed-off-by: Eddie Pavkovic <[email protected]> --------- Signed-off-by: Eddie Pavkovic <[email protected]> Signed-off-by: Andrzej Zukowski <[email protected]> * [ISSUE-1096] Change component version to 1.6.0 Signed-off-by: Andrzej Zukowski <[email protected]> --------- Signed-off-by: Andrzej Zukowski <[email protected]> Signed-off-by: Eddie Pavkovic <[email protected]> Co-authored-by: PrasantDell <[email protected]> Co-authored-by: eddiepavkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
error in lint and unit test from PR #1095
make lint gets the following error:
make test
error:Environment (please complete the following information):
printf "$(uname -srm)\n$(cat /etc/os-release)\n"
]Lint eError
To Reproduce
Expected behavior
It should build
Screenshots
look up
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: