-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a way to disable items in the queue #76
Conversation
Danger has errored[!] Invalid
Generated by 🚫 Danger |
Documentation warnings are false positives (see this). Anyway, there are still some concerns about the implementation I'd like to address:
What do guys think of this? |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
===========================================
- Coverage 75.72% 55.68% -20.04%
===========================================
Files 39 25 -14
Lines 2797 1406 -1391
===========================================
- Hits 2118 783 -1335
+ Misses 679 623 -56
Continue to review full report at Codecov.
|
d002e3c
to
80e1a3a
Compare
In order to avoid multiple delegate calls
80e1a3a
to
5d1f603
Compare
5d1f603
to
0535309
Compare
"What happens if the queue mode is .repeat?" Should play the first item of playlist, no? |
@jadsonlourenco I kind of changed my mind implementing it and went for a repeat mode that doesn't account for the current "availability" of the current item. |
Yes, and |
@jadsonlourenco Yep. Shuffle will just play the shuffled queue and skip "unavailable" items. |
This PR is an implementation of what is discussed in #61. The goal here is to define at runtime - and before an item is played - if an
AudioItem
should be played or not.This allows the original request to disable remote items when WiFi connection is down, but also allows other use cases.
Here's the todo list:
AudioItemQueue
to return the correct values innextItem()
,hasNextItem
,previousItem()
andhasPreviousItem
.