Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce remote items on queue only if there is WiFi connection #61

Closed
wants to merge 4 commits into from

Conversation

jfmiguel
Copy link
Contributor

  • added feature to reproduce remote items on queue only if there is WiFi connection.

@jfmiguel jfmiguel changed the title feature to reproduce remote items on queue only if there is WiFi connection Reproduce remote items on queue only if there is WiFi connection May 17, 2016
…e cleared upon last item on queue reproduction ended
@jfmiguel
Copy link
Contributor Author

  • added stopPlayerAtEndOfQueue flag, to specify if the queue should be cleared upon last item on queue reproduction ended

@jfmiguel jfmiguel closed this May 23, 2016
@jfmiguel jfmiguel reopened this May 23, 2016
@delannoyk
Copy link
Owner

Hi @bw0lff
Thank you for your contribution. I haven't reviewed all the code yet, but I think this could be a nice addition, although I would suggest another way.
What do you think of adding a delegate method/changing the existing func audioPlayer(_:willStartPlayingItem:) to know whether the player should start playing the item or skip it? The default implementation in case the delegate wasn't set would be true. This would obviously leave the check for "WiFi" only items to the user of the player, but that would cover any new case that should happen.

@jfmiguel
Copy link
Contributor Author

Hi @delannoyk,
The suggestions looks great for me but it should also check if is possible to play any other track on the queue (on my proposal I also changed hasNext and added a hasPrevious to do it). maybe instead of a _:willStartPlayingItem: it should have a _:isItemPlayable:, in order to have it generic delegate for both cases.

@delannoyk
Copy link
Owner

Hi @bw0lff
I noticed you updated to Swift 2.3! 👍
Do you want me to close this PR and implement the change we talked about or do you want to update this PR ?
Cheers!

@jfmiguel
Copy link
Contributor Author

HI @delannoyk,

Right now I don't have much time to work on this, therefore the best solution might be the 1st one :)

Thanks

@delannoyk
Copy link
Owner

Neither do I, so I'll leave this open until I get some time - maybe in 2 weeks on my side.

@delannoyk
Copy link
Owner

Closing this as #76 will solve this use case.

@delannoyk delannoyk closed this Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants