refactor: re-implement the slight shim with libcontainer instance #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
force-pushed
the
default-executor-for-slight
branch
from
eb8fb47 to
7f2c09b
Compare
Signed-off-by: jiaxiao zhou <[email protected]>
Mossaka
force-pushed
the
default-executor-for-slight
branch
from
551b637 to
1aae8ed
Compare
|
I've updated this PR to include a few other things
|
Mossaka
force-pushed
the
default-executor-for-slight
branch
from
f4a6fe5 to
c8195d4
Compare
|
Woohoo!! The integration test is passed! |
Mossaka
force-pushed
the
default-executor-for-slight
branch
from
4c0f8e7 to
21752f6
Compare
this allows the CI and makefile to have more configurations Signed-off-by: jiaxiao zhou <[email protected]>
Mossaka
force-pushed
the
default-executor-for-slight
branch
from
21752f6 to
6105fb5
Compare
|
Yay, looks good! If it is ok to build the shims in parallel, it could look like this: |
I created an issue #126 to discuss ways to make the CI faster. Building the shims in parallel is a great idea! Would you like to create a PR for this repo? |
|
Merging it in now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-implements the
slightshim withLibcontainerInstancetrait. This follows #121