feat: add default executor to spin shim #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiaxiao zhou <[email protected]>
|
Hi @Mossaka, |
|
+1 for @0xE282B0's idea. I'm waiting to have a demo on Spin/Dapr as well. |
|
@0xE282B0 thanks for bringing it up. It's in my todo list to build a demo for spin + dapr. I would hugely appreciate your help on this! |
|
Note: the CI failed because it ran into the disk pressure issue. I will be working on emitting artifacts from build and then ran integration tests. |
Signed-off-by: jiaxiao zhou <[email protected]>
This was referenced Aug 18, 2023
this allows the CI and makefile to have more configurations Signed-off-by: jiaxiao zhou <[email protected]>
|
Merging it now. I will make an issue for each TODO item listed in this PR's description. |
This was referenced Aug 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly follows containerd/runwasi#156 to add a default executor alongside with the spin executor. It enables a pod to run both linux containers and spin applications.
TODO: