fix: add working podmonitor for sidekiq #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I put this in draft because while the deployment will work fine and doesnt impact existing functionality (this pod monitor is not there/working currently), a patch is required to uds-core to not overwrite the scrapeClass when its explicitly defined in a PodMonitor resource, which we had to do in this case to enable the All that to say it could be merged right now and then the functionality "works" in the next uds-core patch release. Anyways, visual proof of the active target in prometheus after deploying gitlab against a uds-core build based on the linked PR branch: |
zachariahmiller
commented
Jul 23, 2024
Racer159
approved these changes
Jul 23, 2024
Racer159
pushed a commit
that referenced
this pull request
Jul 23, 2024
🤖 I have created a release *beep* *boop* --- ## [17.1.2-uds.1](v17.1.2-uds.0...v17.1.2-uds.1) (2024-07-23) ### Bug Fixes * add working podmonitor for sidekiq ([#169](#169)) ([5ff550a](5ff550a)) ### Miscellaneous * change playwright to a docker container ([#172](#172)) ([9c805ff](9c805ff)) * **deps:** update gitlab support dependencies ([#170](#170)) ([f02875b](f02875b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #
#165
Type of change
Checklist before merging