Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update monitor mutation to not overwrite explicitly defined scrape class #582

Merged
merged 7 commits into from
Jul 19, 2024

Conversation

zachariahmiller
Copy link
Contributor

Description

  • Updates the behavior of the monitor mutation to not overwrite and explicitly defined scrapeClass

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link
Contributor

@UnicornChance UnicornChance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjnagel mjnagel merged commit 7e550d3 into main Jul 19, 2024
10 checks passed
@mjnagel mjnagel deleted the monitor_mutation_patch branch July 19, 2024 15:40
mjnagel pushed a commit that referenced this pull request Jul 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.24.1](v0.24.0...v0.24.1)
(2024-07-22)


### Bug Fixes

* **ci:** snapshot release publish, passthrough test on upgrade
([#575](#575))
([d4afe00](d4afe00))
* **ci:** workflow permissions
([cacf1b5](cacf1b5))
* only allow istio gateways to set x509 client certificate header
([#572](#572))
([5c62279](5c62279))
* **sso:** delete orphaned SSO secrets
([#578](#578))
([5a6b9ef](5a6b9ef))
* unicorn flavor proxy image reference
([#590](#590))
([db081fa](db081fa))
* update monitor mutation to not overwrite explicitly defined scrape
class ([#582](#582))
([7e550d3](7e550d3))


### Miscellaneous

* **deps:** update grafana chart + sidecar image
([#567](#567))
([85b6de4](85b6de4))
* **deps:** update pepr to v0.32.7
([#556](#556))
([e594f13](e594f13))
* **deps:** update uds-identity-config to v0.5.1
([#591](#591))
([b9c5bd3](b9c5bd3))
* **deps:** update uds-k3d to v0.8.0
([#581](#581))
([fab8919](fab8919))
* **loki:** default query settings, config as secret
([#579](#579))
([5fa889c](5fa889c))
* **oscal:** begin integration of composed oscal with validations
([#496](#496))
([047fd30](047fd30))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants