chore: resolve max statement in watch-processor #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <[email protected]>
5 tasks
github-merge-queue bot
pushed a commit
to defenseunicorns/kubernetes-fluent-client
that referenced
this pull request
Feb 5, 2025
## Description This type is required for Pepr [1770](defenseunicorns/pepr#1770) to reduce complexity ## Related Issue Fixes # <!-- or --> Relates to #[1770](defenseunicorns/pepr#1770) ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1770 +/- ##
==========================================
+ Coverage 82.05% 82.11% +0.06%
==========================================
Files 52 52
Lines 2212 2214 +2
Branches 470 469 -1
==========================================
+ Hits 1815 1818 +3
- Misses 368 394 +26
+ Partials 29 2 -27
|
samayer12
reviewed
Feb 5, 2025
samayer12
reviewed
Feb 5, 2025
samayer12
previously approved these changes
Feb 5, 2025
Co-authored-by: Sam Mayer <[email protected]>
samayer12
approved these changes
Feb 7, 2025
tamirazrab
pushed a commit
to tamirazrab/pepr
that referenced
this pull request
Feb 10, 2025
## Description Reduce max-statements in watch-processor around watch. This PR depends on a KFC release ## Related Issue Fixes defenseunicorns#1697 <!-- or --> Relates to # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Signed-off-by: Case Wylie <[email protected]> Co-authored-by: Sam Mayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce max-statements in watch-processor around watch. This PR depends on a KFC release
Related Issue
Fixes #1697
Relates to #
Type of change
Checklist before merging