Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use it.each() in watch-processor tests #1772

Closed
samayer12 opened this issue Feb 5, 2025 · 0 comments · Fixed by #1784
Closed

Use it.each() in watch-processor tests #1772

samayer12 opened this issue Feb 5, 2025 · 0 comments · Fixed by #1784
Assignees
@cmwylie19
Labels
tech-debt Testing Testing

Comments

@samayer12
Copy link
Contributor

Describe what should be investigated or refactored

#1770 addressed some linter issues with the watch-processor and added some tests (yay!). The particular type of tests that were added seem like good candidates for the it.each() construct in jest. Let's refactor the tests to take advantage of that way of writing tests.

Links to any relevant code

Additional context
@cmwylie19 cmwylie19 self-assigned this Feb 6, 2025
@cmwylie19 cmwylie19 moved this from 🆕 New to 🏗 In progress in Pepr Project Board Feb 7, 2025
@samayer12 samayer12 added the Testing Testing label Feb 7, 2025
@cmwylie19 cmwylie19 mentioned this issue Feb 7, 2025
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 10, 2025
@cmwylie19 @samayer12
chore: use it.each() in related test cases (#1784)
b8ab147 
## Description

Use `it.each()` in registrerWatchEventHandlers` test

## Related Issue

Fixes #1772 
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

Signed-off-by: Case Wylie <[email protected]>
Co-authored-by: Sam Mayer <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Pepr Project Board Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwylie19 cmwylie19

Labels
tech-debt Testing Testing
Projects
Pepr Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use it.each() in related test cases defenseunicorns/pepr
2 participants
@cmwylie19 @samayer12