-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add typing to templates.ts #1602
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
==========================================
+ Coverage 81.24% 81.31% +0.06%
==========================================
Files 42 43 +1
Lines 1962 1969 +7
Branches 432 407 -25
==========================================
+ Hits 1594 1601 +7
- Misses 340 366 +26
+ Partials 28 2 -26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now lets keep RBAC mode wide open since this would be a major change. Other than that it is all good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Nice
Description
Adds typing to
templates.ts
End to End Test:
(See Pepr Excellent Examples)
Related Issue
Relates to #1364
Type of change
Checklist before merging