Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add typing to templates.ts #1602

Merged
merged 8 commits into from
Jan 6, 2025
Merged

chore: add typing to templates.ts #1602

merged 8 commits into from
Jan 6, 2025

Conversation

samayer12
Copy link
Collaborator

Description

Adds typing to templates.ts

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Relates to #1364

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@samayer12 samayer12 requested a review from a team as a code owner December 18, 2024 15:48
@samayer12 samayer12 self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.31%. Comparing base (cd03899) to head (64994f1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/processors/mutate-processor.ts 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1602      +/-   ##
==========================================
+ Coverage   81.24%   81.31%   +0.06%     
==========================================
  Files          42       43       +1     
  Lines        1962     1969       +7     
  Branches      432      407      -25     
==========================================
+ Hits         1594     1601       +7     
- Misses        340      366      +26     
+ Partials       28        2      -26     
Files with missing lines Coverage Δ
src/cli/init/enums.ts 100.00% <100.00%> (ø)
src/cli/init/templates.ts 70.58% <100.00%> (ø)
src/cli/init/walkthrough.ts 88.00% <100.00%> (ø)
src/lib/errors.ts 100.00% <100.00%> (ø)
src/lib/processors/mutate-processor.ts 62.63% <75.00%> (ø)

... and 6 files with indirect coverage changes

src/cli/init/enums.ts Outdated Show resolved Hide resolved
src/cli/init/templates.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@cmwylie19 cmwylie19 enabled auto-merge December 20, 2024 18:41
@cmwylie19 cmwylie19 disabled auto-merge December 20, 2024 19:18
@cmwylie19 cmwylie19 self-requested a review December 20, 2024 19:18
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now lets keep RBAC mode wide open since this would be a major change. Other than that it is all good.

@samayer12 samayer12 requested a review from cmwylie19 January 6, 2025 17:45
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice

@cmwylie19 cmwylie19 added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 1955962 Jan 6, 2025
48 checks passed
@cmwylie19 cmwylie19 deleted the type-templates branch January 6, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants