-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: encourage return types in function definitions #1364
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 43 43
Lines 1979 1979
Branches 430 411 -19
=======================================
Hits 1611 1611
- Misses 340 366 +26
+ Partials 28 2 -26 |
7c0cc20
to
adfacf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This will help us track down these issues.
This PR would make the logs pretty noisy, but is useful for the project. After discussion with @btlghrants, we're opted to put this on hold while we work on other outstanding refactors (e.g., #1248, #1371, #1250, #1247, etc). This PR will be suitable to revisit once the existing set of linter warnings are resolved. |
## Description Adds typing to `templates.ts` End to End Test: <!-- if applicable --> (See [Pepr Excellent Examples](https://github.com/defenseunicorns/pepr-excellent-examples)) ## Related Issue Relates to #1364 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <[email protected]>
Description
Encourage non-test code to specify return types.
Related Issue
Hotifx
Type of change
Checklist before merging