Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: resolve eslint warnings (max-depth, complexity) - src/cli/deploy.ts #1577

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

btlghrants
Copy link
Collaborator

Describe what should be investigated or refactored

Refactor of src/cli/deploy.ts to reduce complexity warnings:

/pepr/src/cli/deploy.ts
  28:13  warning  Async arrow function has too many statements (27). Maximum allowed is 20  max-statements
  28:13  warning  Async arrow function has a complexity of 17. Maximum allowed is 10        complexity

Additional context

Fixes #1538
In support of #1248

@btlghrants btlghrants self-assigned this Dec 13, 2024
@btlghrants btlghrants added this to the v0.42.2 milestone Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (ac27ad4) to head (7cb117e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1577   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files          42       42           
  Lines        1952     1952           
  Branches      451      424   -27     
=======================================
  Hits         1578     1578           
  Misses        372      372           
  Partials        2        2           

@btlghrants btlghrants marked this pull request as ready for review December 13, 2024 21:03
@btlghrants btlghrants requested a review from a team as a code owner December 13, 2024 21:03
src/cli/deploy.ts Outdated Show resolved Hide resolved
Co-authored-by: Case Wylie <[email protected]>
Copy link
Collaborator

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor, breaks this gnarly block of deployment code into something much more manageable.

@btlghrants btlghrants added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 58ed6b5 Dec 13, 2024
48 checks passed
@btlghrants btlghrants deleted the 1538_deploy_ts_complexity branch December 13, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

complexity of deploy.ts
3 participants