Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complexity of deploy.ts #1538

Closed
cmwylie19 opened this issue Dec 6, 2024 · 0 comments · Fixed by #1577
Closed

complexity of deploy.ts #1538

cmwylie19 opened this issue Dec 6, 2024 · 0 comments · Fixed by #1577
Assignees
@btlghrants
Labels
complexity complexity tech-debt
Milestone
v0.42.2

Comments

@cmwylie19
Copy link
Contributor

Describe what should be investigated or refactored

  27:13  warning  Async arrow function has a complexity of 17. Maximum allowed is 10        complexity
@cmwylie19 cmwylie19 added this to the v0.43.0 milestone Dec 6, 2024
@cmwylie19 cmwylie19 moved this from 🆕 New to 📋 Backlog in Pepr Project Board Dec 9, 2024
@btlghrants btlghrants moved this from 📋 Backlog to 🏗 In progress in Pepr Project Board Dec 13, 2024
@btlghrants btlghrants mentioned this issue Dec 13, 2024
Merged
@btlghrants btlghrants moved this from 🏗 In progress to 👀 In review in Pepr Project Board Dec 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2024
@btlghrants @cmwylie19
refactor: resolve eslint warnings (max-depth, complexity) - src/cli/d…
58ed6b5 
…eploy.ts (#1577)

### Describe what should be investigated or refactored

Refactor of `src/cli/deploy.ts` to reduce complexity warnings:
```
/pepr/src/cli/deploy.ts
  28:13  warning  Async arrow function has too many statements (27). Maximum allowed is 20  max-statements
  28:13  warning  Async arrow function has a complexity of 17. Maximum allowed is 10        complexity
```

### Additional context
Fixes #1538 
In support of #1248

---------

Co-authored-by: Case Wylie <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Pepr Project Board Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btlghrants btlghrants

Labels
complexity complexity tech-debt
Projects
Pepr Project Board
Archived in project
Milestone
v0.42.2
Development

Successfully merging a pull request may close this issue.

refactor: resolve eslint warnings (max-depth, complexity) - src/cli/deploy.ts defenseunicorns/pepr
2 participants
@cmwylie19 @btlghrants