Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pin pydantic to 1.9.2 #3126

Merged
merged 1 commit into from
Aug 31, 2022
Merged

build: pin pydantic to 1.9.2 #3126

merged 1 commit into from
Aug 31, 2022

Conversation

masci
Copy link
Contributor

@masci masci commented Aug 31, 2022

Related Issues

Proposed Changes:

Pin pydantic to 1.9.2

Pydantic 1.10 ships a heavy refactoring of the dataclass decorator that we use, causing multiple failures. While we investigate the problem, this should bring back the CI to a healthy state.

How did you test it?

Notes for the reviewer

Checklist

@masci masci requested a review from a team as a code owner August 31, 2022 11:47
@masci masci requested review from julian-risch and removed request for a team August 31, 2022 11:47
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to solve the issue. Approved. 👍 Please adjust the PR title to adhere to our conventional commit convention before merging.

@masci masci changed the title Pin pydantic to 1.9.2 build: pin pydantic to 1.9.2 Aug 31, 2022
@masci masci merged commit ffee36c into main Aug 31, 2022
@masci masci deleted the massi/pin-pydantic branch August 31, 2022 12:36
@masci masci mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants