Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pin from pydantic #3128

Closed
masci opened this issue Aug 31, 2022 · 1 comment · Fixed by #3142
Closed

Remove pin from pydantic #3128

masci opened this issue Aug 31, 2022 · 1 comment · Fixed by #3142

Comments

@masci
Copy link
Contributor

masci commented Aug 31, 2022

Is your feature request related to a problem? Please describe.
We had several tests failing after the release of pydantic 1.10 and we pinned the version to an older one but we should stay up to date as that's an important dependency for Haystack.

Describe the solution you'd like
Remove the pin and fix the test failures (those are mostly related to the new dataclass decorator that we use e.g. in Document)

@danielbichuetti
Copy link
Contributor

The main reason is related to some initialization pydantic do into dataclasses for his own internal logic. These extra fields were being mutated to Document.meta in reason of its logic.

One solution that I can see is filtering new pydantic current initialization variable.

I'll post a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants