Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xpdf to 4.0.4 #2443

Merged
merged 5 commits into from
Apr 21, 2022
Merged

Upgrade xpdf to 4.0.4 #2443

merged 5 commits into from
Apr 21, 2022

Conversation

tholor
Copy link
Member

@tholor tholor commented Apr 21, 2022

Proposed changes:
xpdf released a new version on Apr 18th. As they only host the latest version of command line tools, our docker builds failed as the old tar was not available anymore.

Upgraded it quickly to 4.0.4 but haven't verified if there were any breaking changes in their release.

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@tholor tholor requested a review from julian-risch April 21, 2022 07:06
@ZanSara
Copy link
Contributor

ZanSara commented Apr 21, 2022

I have upgraded the same links in the CI two days ago (#2432) and I've noticed no new tests failing, so I assume it's all good wrt compatibility. I should have thought about the Dockerfiles too in that PR 😅

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 I had a brief look at the changes that came with the upgrade from 4.0.3 to 4.0.4. Nothing that I'd expect to break something on our end. Some additional flags/functionalities added to pdftohtml are the main changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants