Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pdftotext link #2432

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Update pdftotext link #2432

merged 3 commits into from
Apr 19, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Apr 19, 2022

A new release of pdftotext broke the CI. This PR fixes it.

@ZanSara ZanSara requested a review from julian-risch April 19, 2022 10:06
@ZanSara ZanSara added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 19, 2022
@ZanSara ZanSara requested a review from tstadel April 19, 2022 10:12
@ZanSara ZanSara mentioned this pull request Apr 19, 2022
Merged
2 tasks
julian-risch
julian-risch approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 One remark: if the CI has problems with version 4.03, maybe we should upgrade the version in tutorial 8 also from 4.03 to 4.04?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ZanSara ZanSara merged commit ba9c976 into master Apr 19, 2022
@ZanSara ZanSara deleted the update_pdftotext_in_ci branch April 19, 2022 12:30
@ZanSara ZanSara mentioned this pull request Apr 19, 2022
Merged
@ZanSara ZanSara mentioned this pull request Apr 21, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@tstadel tstadel Awaiting requested review from tstadel

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZanSara @julian-risch