-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log evaluation results to MLflow #2337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great draft. I made many comments that are best to discuss in a call I believe.
Seems like the test
And mypy:
|
Mypy issues is fixed. The other was probably a glitch in the (elasticsearch) environment. Seems like the scroll of 1000 docs ran out of mem. As this test is in place for quite a while I would mark this as very rare event that probably won't happen again. However we should monitor the tests and if it does happen again we can decrease the batch_size during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@tstadel Let's make sure this new feature is properly documented on the website. Maybe you could sync on that topic with @brandenchan ? |
Proposed changes:
execute_eval_run()
toPipeline
which encapsulatespipeline.eval()
and logs to MLflow via a MLflowTrackingHeadMLFlowLogger
:Tracker
facade that can utilize different TackingHeads by callingTracker.set_tracking_head()
MLflowTrackingHead
withauto_track_environment
paramUsage:
Status (please check what you already did):
closes #2188