-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove set_prefix
#219
remove set_prefix
#219
Conversation
WalkthroughWalkthroughThe update primarily consists of simplifying the training configuration by eliminating the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedRuff (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (6)
tests/op/test_prep_dp_train.py (6)
Line range hint
8-8
: Remove unused import ofnumpy
.- import numpy as np
Line range hint
10-10
: Remove unused import ofdflow.python.OP
.- from dflow.python import OP
Line range hint
12-12
: Remove unused import ofdflow.python.Artifact
.- from dflow.python import Artifact
Line range hint
13-13
: Remove unused import ofdflow.python.OPIOSign
.- from dflow.python import OPIOSign
Line range hint
21-21
: Remove unused import of.context.dpgen2
.- from .context import dpgen2
Line range hint
179-179
: The local variableop
is assigned but never used in the methodtest_template_raise_wrong_list_length
.- op = self.ptrain.execute(ip)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 84.98% 84.98%
=======================================
Files 94 94
Lines 5114 5114
=======================================
Hits 4346 4346
Misses 768 768 ☔ View full report in Codecov by Sentry. |
See:
set_prefix
doesn't work for both TF and PT deepmd-kit#3477set_prefix
deepmd-kit#3753Summary by CodeRabbit