Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove set_prefix #219

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 6, 2024

See:

Summary by CodeRabbit

  • Refactor
    • Removed an unused configuration parameter from the training settings.

Copy link

coderabbitai bot commented May 6, 2024

Walkthrough

Walkthrough

The update primarily consists of simplifying the training configuration by eliminating the set_prefix parameter from the settings in the test_prep_dp_train.py file. This change streamlines the setup process for training, possibly enhancing clarity and reducing configuration complexity.

Changes

File Change Summary
tests/op/test_prep_dp_train.py Removed "set_prefix": "set" from the training settings.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 07df321 and cd6e9fc.
Files selected for processing (1)
  • tests/op/test_prep_dp_train.py (2 hunks)
Additional Context Used
Ruff (6)
tests/op/test_prep_dp_train.py (6)

8-8: numpy imported but unused


10-10: dflow.python.OP imported but unused


12-12: dflow.python.Artifact imported but unused


13-13: dflow.python.OPIOSign imported but unused


21-21: .context.dpgen2 imported but unused


179-179: Local variable op is assigned to but never used


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (6)
tests/op/test_prep_dp_train.py (6)

Line range hint 8-8: Remove unused import of numpy.

- import numpy as np

Line range hint 10-10: Remove unused import of dflow.python.OP.

- from dflow.python import OP

Line range hint 12-12: Remove unused import of dflow.python.Artifact.

- from dflow.python import Artifact

Line range hint 13-13: Remove unused import of dflow.python.OPIOSign.

- from dflow.python import OPIOSign

Line range hint 21-21: Remove unused import of .context.dpgen2.

- from .context import dpgen2

Line range hint 179-179: The local variable op is assigned but never used in the method test_template_raise_wrong_list_length.

- op = self.ptrain.execute(ip)

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.98%. Comparing base (07df321) to head (cd6e9fc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files          94       94           
  Lines        5114     5114           
=======================================
  Hits         4346     4346           
  Misses        768      768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 1c7a268 into deepmodeling:master May 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants