-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] set_prefix
doesn't work for both TF and PT
#3477
Comments
github-project-automation
bot
moved this to Todo
in Multiple backend support for DeePMD-kit
Mar 17, 2024
We will remove support for |
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this issue
May 6, 2024
Fix deepmodeling#3477. Deprecate `set_prefix` in the training parameter and `--set-prefix` in CLI. It has been broken since several years ago, and dpdata only supports `set`. Signed-off-by: Jinzhe Zeng <[email protected]>
njzjz
added a commit
to njzjz/dpgen
that referenced
this issue
May 6, 2024
njzjz
added a commit
to njzjz/dpgen2
that referenced
this issue
May 6, 2024
njzjz
added a commit
to njzjz/tutorials
that referenced
this issue
May 6, 2024
wanghan-iapcm
pushed a commit
to deepmodeling/dpgen2
that referenced
this issue
May 7, 2024
See: - deepmodeling/deepmd-kit#3477 - deepmodeling/deepmd-kit#3753 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed an unused configuration parameter from the training settings. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
wanghan-iapcm
added a commit
to deepmodeling/dpgen
that referenced
this issue
May 7, 2024
See: - deepmodeling/deepmd-kit#3477 - deepmodeling/deepmd-kit#3753 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed the `"set_prefix": "set"` attribute across various JSON and YAML configuration files, streamlining data handling and batch processing setups. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Han Wang <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
May 7, 2024
Fix #3477. Deprecate `set_prefix` in the training parameter and `--set-prefix` in CLI. It has been broken since several years ago, and dpdata only supports `set`. --------- Signed-off-by: Jinzhe Zeng <[email protected]>
github-project-automation
bot
moved this from Todo
to Done
in Multiple backend support for DeePMD-kit
May 7, 2024
github-project-automation
bot
moved this from Backlog
to Done
in DeePMD-3.0.0 beta release
May 7, 2024
njzjz
added a commit
to deepmodeling/tutorials
that referenced
this issue
Aug 9, 2024
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this issue
Sep 18, 2024
Fix deepmodeling#3477. Deprecate `set_prefix` in the training parameter and `--set-prefix` in CLI. It has been broken since several years ago, and dpdata only supports `set`. --------- Signed-off-by: Jinzhe Zeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug summary
set_prefix
cannot be changed to other values exceptset
in both TensorFlow and PyTorch backends.We should remove such an option, or allow it to exist for compatibility but disallow other options and update the documentation.
DeePMD-kit Version
v3.0.0a0-28-ged831c88
TensorFlow Version
PT v2.2.0+cu121-g8ac9b20d4b0
How did you download the software?
Built from source
Input Files, Running Commands, Error Log, etc.
The
get_data
method doesn't have this argument, as shown below.Steps to Reproduce
cd examples/water/data
Change the prefix of all training data from
set
tohaha
.Then go to
cd examples/water/se_atten
Add
set_prefix
option:Further Information, Files, and Links
No response
The text was updated successfully, but these errors were encountered: