Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Consistent test for DPA2 only reaches around 1e-10 atol between pt & dp #3786

Closed
iProzd opened this issue May 15, 2024 · 2 comments
Closed

[BUG] Consistent test for DPA2 only reaches around 1e-10 atol between pt & dp #3786

iProzd opened this issue May 15, 2024 · 2 comments
Assignees
@iProzd
Labels
bug

Comments

@iProzd
Copy link
Collaborator

iProzd commented May 15, 2024

Bug summary

Consistent test for DPA2 only reaches around 1e-10 atol between pt & dp.
Located in repformer_update_g1_has_attn but still needs figuring out.

DeePMD-kit Version

3.0.0a

Backend and its version

PyTorch v2.1.2

How did you download the software?

Offline packages

Input Files, Running Commands, Error Log, etc.

See above.

Steps to Reproduce

See above.

Further Information, Files, and Links

See above.
@iProzd iProzd added the bug label May 15, 2024
@iProzd iProzd mentioned this issue May 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 16, 2024
@iProzd
chore(pt): lower the atol for dpa2 test (#3785)
b2b126b 
Opened an issue about this:
#3786

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Adjusted tolerance values to improve the precision consistency for
specific tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@iProzd iProzd self-assigned this Jun 24, 2024
@njzjz
Copy link
Member

njzjz commented Jul 24, 2024

Do we want to resolve the issue or close it?

@iProzd
Copy link
Collaborator Author

iProzd commented Jul 24, 2024

We should close it, since it's a numerical error which has been discussed.

@iProzd iProzd closed this as completed Jul 24, 2024
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@iProzd @mtaillefumier
chore(pt): lower the atol for dpa2 test (deepmodeling#3785)
c57b7f5 
Opened an issue about this:
deepmodeling#3786

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Adjusted tolerance values to improve the precision consistency for
specific tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iProzd iProzd

Labels
bug
Projects
No open projects
DeePMD-3.0.0 beta release
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@njzjz @iProzd