feat: Adjustable grid density and icon size #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the work needed for deephaven#885 that I felt would be better as a separate PR. Snapshot changes are going to be slightly shifted sort icon and vertical center + slight left shift on tree table arrows.
Fixes deephaven#885 This adds a user setting for grid density in the theme section which applies to all grids without an explicit density prop. A separate dh.ui PR will allow setting the density per table and is not influenced by the global density setting.
…n#2187) This is only an issue if we directly set a public member. In the current proxy model, we only set via `setField` type functions, so things seem to be fine. Inside of class definitions the proxy is skipped (since the proxy is just returned from the ctor). This change makes setting a member defined in the proxy class work even if you try to do it on the proxy object. ```ts class ProxyModel { myField = 4 } test = new ProxyModel(); test.myField; // 4 test.model.myField; // undefined test.myField = 5; test.myField; // 4 - WRONG test.model.myField; // 5 ```
mattrunyon
approved these changes
Jan 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui.tabledensity that's in deephaven.ui v0.23.1