-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to increase information density #885
Option to increase information density #885
Comments
In practice, on a fresh console running a single command, we are showing 6 rows less than swing. We lose a bit of space from browser chrome, but also we are proportionally allocating more space to the console (we have less ui-chrome in the console panel). So we could reduce it's default height and still be comparable. Currently it's 50/50 split, but maybe 40/60 or something would be a better default. Our tabs are slightly taller, and so are out header columns, but I think there's value in that in terms of click target size and would prefer to squeeze elsewhere. |
- Reduces spacing between commands - Increases button height slightly, but reduces padding - Aligns gutter "-" with button - Adopts Button component - Cleans up CSS a bit, share constants between files --- - Relates to "Option to increase information density" #885 - Relates to "Reduce the console height to 40/60 split in the default layout" #929
* Slightly reduce padding between console commands - Reduces spacing between commands - Increases button height slightly, but reduces padding - Aligns gutter "-" with button - Adopts Button component - Cleans up CSS a bit, share constants between files --- - Relates to "Option to increase information density" #885 - Relates to "Reduce the console height to 40/60 split in the default layout" #929
Just adding another example to this: These two screenshots were taken w/ the boundaries between the charts/tables exactly lined up, more or less to the pixel. Here is the second screenshot again, with font size increased to 12: This give me a few thoughts:
|
That's useful feedback. Thanks for the screenshots.
We have the same logic. I think we are too zealous with the horizontal padding on the headers, which combined with the font-size difference probably accounts for most of the horizontal difference.
Possibly reserving space for the x-axis label even though none is set?
This is one spot I think the extra couple vertical pixels are worth spending, as the headers act as buttons. The sort/reverse indicator bars also use this reserved space. We should shave it everywhere else though. |
This is part of the work needed for #885 that I felt would be better as a separate PR. Snapshot changes are going to be slightly shifted sort icon and vertical center + slight left shift on tree table arrows.
## Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.86.0 ### Features * Add option to disable WebGL rendering ([#2134](deephaven/web-client-ui#2134)) ([011eb33](deephaven/web-client-ui@011eb33)) * Core plugins refactor, XComponent framework ([#2150](deephaven/web-client-ui#2150)) ([2571fad](deephaven/web-client-ui@2571fad)) * IrisGridTheme iconSize ([#2123](deephaven/web-client-ui#2123)) ([58ee88d](deephaven/web-client-ui@58ee88d)), closes [#885](deephaven/web-client-ui#885) * Partitioned Table UI Enhancements ([#2110](deephaven/web-client-ui#2110)) ([de5ce40](deephaven/web-client-ui@de5ce40)), closes [#2079](deephaven/web-client-ui#2079) [#2066](deephaven/web-client-ui#2066) [#2103](deephaven/web-client-ui#2103) [#2104](deephaven/web-client-ui#2104) [#2105](deephaven/web-client-ui#2105) [#2106](deephaven/web-client-ui#2106) [#2107](deephaven/web-client-ui#2107) [#2108](deephaven/web-client-ui#2108) [#2109](deephaven/web-client-ui#2109) [#2049](deephaven/web-client-ui#2049) [#2120](deephaven/web-client-ui#2120) [#1904](deephaven/web-client-ui#1904) ### Bug Fixes * error when edited cell is out of grid viewport ([#2148](deephaven/web-client-ui#2148)) ([3fccd43](deephaven/web-client-ui@3fccd43)), closes [#2087](deephaven/web-client-ui#2087) ## Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.85.2 ### Bug Fixes * Fix missing scrim background on LoadingOverlay ([#2098](deephaven/web-client-ui#2098)) ([c9ed895](deephaven/web-client-ui@c9ed895)) ## Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.85.1 ## [0.85.1](deephaven/web-client-ui@v0.85.0...v0.85.1) (2024-07-08) ### Bug Fixes * re-export remaining types needed by dh ui from @react-types/shared ([#2132](deephaven/web-client-ui#2132)) ([2119a61](deephaven/web-client-ui@2119a61)) ## Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.85.0 ### Features * ComboBox - @deephaven/jsapi-components ([#2077](deephaven/web-client-ui#2077)) ([115e057](deephaven/web-client-ui@115e057)), closes [#2074](deephaven/web-client-ui#2074) ### Bug Fixes * Allow ComboBox to accept the FocusableRef for ref ([#2121](deephaven/web-client-ui#2121)) ([8fe9bad](deephaven/web-client-ui@8fe9bad)) * Ref was not being passed through for Picker ([#2122](deephaven/web-client-ui#2122)) ([a11e2ce](deephaven/web-client-ui@a11e2ce)) Co-authored-by: deephaven-internal <[email protected]>
This is part of the work needed for deephaven#885 that I felt would be better as a separate PR. Snapshot changes are going to be slightly shifted sort icon and vertical center + slight left shift on tree table arrows.
Fixes deephaven#885 This adds a user setting for grid density in the theme section which applies to all grids without an explicit density prop. A separate dh.ui PR will allow setting the density per table and is not influenced by the global density setting.
As a power user, I want increase the information density to allow for more information to appear on the screen at once. Things like reducing column/row padding in grids, decreasing font size, decreasing padding in plots, decreasing tab padding/size, etc.
The text was updated successfully, but these errors were encountered: