Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to increase information density #885

Closed
mofojed opened this issue Nov 15, 2022 · 5 comments · Fixed by #2151 or deephaven/deephaven-core#5790
Closed

Option to increase information density #885

mofojed opened this issue Nov 15, 2022 · 5 comments · Fixed by #2151 or deephaven/deephaven-core#5790
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Nov 15, 2022

As a power user, I want increase the information density to allow for more information to appear on the screen at once. Things like reducing column/row padding in grids, decreasing font size, decreasing padding in plots, decreasing tab padding/size, etc.

@mofojed mofojed added enhancement New feature or request triage Issue requires triage labels Nov 15, 2022
@dsmmcken
Copy link
Contributor

We default slightly higher in font-size and in cell y-padding, and marginally higher in x-padding. A higher density option that lowers font-size and padding would increase density, we should also offer the reverse.

image

@dsmmcken
Copy link
Contributor

In terms of just the table:
image

1px taller text, and overall cell height is 3px taller per cell.

Horizontally it's mixed, some cells are wider by default some are narrower, but padding is still larger. Overall though we come out slightly wider.
image

@dsmmcken
Copy link
Contributor

In practice, on a fresh console running a single command, we are showing 6 rows less than swing. We lose a bit of space from browser chrome, but also we are proportionally allocating more space to the console (we have less ui-chrome in the console panel). So we could reduce it's default height and still be comparable. Currently it's 50/50 split, but maybe 40/60 or something would be a better default. Our tabs are slightly taller, and so are out header columns, but I think there's value in that in terms of click target size and would prefer to squeeze elsewhere.

ui-chrome-comparison

@vbabich vbabich added this to the December 2022 milestone Nov 16, 2022
@vbabich vbabich removed the triage Issue requires triage label Nov 16, 2022
dsmmcken added a commit that referenced this issue Dec 6, 2022
- Reduces spacing between commands
- Increases button height slightly, but reduces padding
- Aligns gutter "-" with button
- Adopts Button component
- Cleans up CSS a bit, share constants between files
---
- Relates to "Option to increase information density" #885
- Relates to "Reduce the console height to 40/60 split in the default layout" #929
dsmmcken added a commit that referenced this issue Dec 8, 2022
* Slightly reduce padding between console commands

- Reduces spacing between commands
- Increases button height slightly, but reduces padding
- Aligns gutter "-" with button
- Adopts Button component
- Cleans up CSS a bit, share constants between files
---
- Relates to "Option to increase information density" #885
- Relates to "Reduce the console height to 40/60 split in the default layout" #929
@mofojed mofojed modified the milestones: December 2022, January 2023 Dec 28, 2022
@mofojed mofojed modified the milestones: January 2023, February 2023 Feb 8, 2023
@mofojed mofojed modified the milestones: February 2023, Backlog Feb 27, 2023
@rbasralian
Copy link

Just adding another example to this:

image

image

These two screenshots were taken w/ the boundaries between the charts/tables exactly lined up, more or less to the pixel.

Here is the second screenshot again, with font size increased to 12:

image

This give me a few thoughts:

  • The web UI should let users change the table header/text font sizes.
  • The web should support 'auto resize all columns' like Swing does, which should make the column widths fit the headers very tightly, so more columns fit on screen. (I think the Swing rule is that it the header or the data, whichever is wider, up to some reasonable max # of pixels.)
  • The web plots are wasting a decent amount of space below the plot.
  • The column headers could probably have a bit less padding on top/bottom.

@dsmmcken
Copy link
Contributor

dsmmcken commented Apr 18, 2023

That's useful feedback. Thanks for the screenshots.

the header or the data, whichever is wider

We have the same logic. I think we are too zealous with the horizontal padding on the headers, which combined with the font-size difference probably accounts for most of the horizontal difference.

The web plots are wasting a decent amount of space below the plot.

Possibly reserving space for the x-axis label even though none is set?

The column headers could probably have a bit less padding on top/bottom.

This is one spot I think the extra couple vertical pixels are worth spending, as the headers act as buttons. The sort/reverse indicator bars also use this reserved space. We should shave it everywhere else though.

@mattrunyon mattrunyon self-assigned this Jul 2, 2024
@mattrunyon mattrunyon modified the milestones: Backlog, July 2024 Jul 2, 2024
mattrunyon added a commit that referenced this issue Jul 16, 2024
This is part of the work needed for #885 that I felt would be better as
a separate PR.

Snapshot changes are going to be slightly shifted sort icon and vertical
center + slight left shift on tree table arrows.
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Jul 17, 2024
## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.86.0

### Features

* Add option to disable WebGL rendering
([#2134](deephaven/web-client-ui#2134))
([011eb33](deephaven/web-client-ui@011eb33))
* Core plugins refactor, XComponent framework
([#2150](deephaven/web-client-ui#2150))
([2571fad](deephaven/web-client-ui@2571fad))
* IrisGridTheme iconSize
([#2123](deephaven/web-client-ui#2123))
([58ee88d](deephaven/web-client-ui@58ee88d)),
closes [#885](deephaven/web-client-ui#885)
* Partitioned Table UI Enhancements
([#2110](deephaven/web-client-ui#2110))
([de5ce40](deephaven/web-client-ui@de5ce40)),
closes [#2079](deephaven/web-client-ui#2079)
[#2066](deephaven/web-client-ui#2066)
[#2103](deephaven/web-client-ui#2103)
[#2104](deephaven/web-client-ui#2104)
[#2105](deephaven/web-client-ui#2105)
[#2106](deephaven/web-client-ui#2106)
[#2107](deephaven/web-client-ui#2107)
[#2108](deephaven/web-client-ui#2108)
[#2109](deephaven/web-client-ui#2109)
[#2049](deephaven/web-client-ui#2049)
[#2120](deephaven/web-client-ui#2120)
[#1904](deephaven/web-client-ui#1904)


### Bug Fixes

* error when edited cell is out of grid viewport
([#2148](deephaven/web-client-ui#2148))
([3fccd43](deephaven/web-client-ui@3fccd43)),
closes [#2087](deephaven/web-client-ui#2087)

## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.2


### Bug Fixes

* Fix missing scrim background on LoadingOverlay
([#2098](deephaven/web-client-ui#2098))
([c9ed895](deephaven/web-client-ui@c9ed895))

## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.1

##
[0.85.1](deephaven/web-client-ui@v0.85.0...v0.85.1)
(2024-07-08)


### Bug Fixes

* re-export remaining types needed by dh ui from @react-types/shared
([#2132](deephaven/web-client-ui#2132))
([2119a61](deephaven/web-client-ui@2119a61))



## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.0

### Features

* ComboBox - @deephaven/jsapi-components
([#2077](deephaven/web-client-ui#2077))
([115e057](deephaven/web-client-ui@115e057)),
closes [#2074](deephaven/web-client-ui#2074)


### Bug Fixes

* Allow ComboBox to accept the FocusableRef for ref
([#2121](deephaven/web-client-ui#2121))
([8fe9bad](deephaven/web-client-ui@8fe9bad))
* Ref was not being passed through for Picker
([#2122](deephaven/web-client-ui#2122))
([a11e2ce](deephaven/web-client-ui@a11e2ce))

Co-authored-by: deephaven-internal <[email protected]>
@mattrunyon mattrunyon reopened this Jul 17, 2024
mofojed pushed a commit to mofojed/web-client-ui that referenced this issue Jan 6, 2025
This is part of the work needed for deephaven#885 that I felt would be better as
a separate PR.

Snapshot changes are going to be slightly shifted sort icon and vertical
center + slight left shift on tree table arrows.
mofojed pushed a commit to mofojed/web-client-ui that referenced this issue Jan 6, 2025
Fixes deephaven#885 

This adds a user setting for grid density in the theme section which
applies to all grids without an explicit density prop. A separate dh.ui
PR will allow setting the density per table and is not influenced by the
global density setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment