-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Save/load plugin data with layout #1866
fix: Save/load plugin data with layout #1866
Conversation
mofojed
commented
Mar 11, 2024
•
edited
Loading
edited
- Plugin data was not getting saved with the workspace
- Reload the dashboard when a layout is imported by updating the key
- Fixes Exported layouts do not contain pluginDataMap #1861
- Needed to use deephaven.ui from a layout in app mode
- Forces the plugins to reload as well, which gets the pluginDataMap to load correctly for deephaven.ui
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
+ Coverage 46.11% 46.15% +0.03%
==========================================
Files 636 636
Lines 38070 38071 +1
Branches 9627 9627
==========================================
+ Hits 17556 17570 +14
+ Misses 20461 20448 -13
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
const { filterSets, layoutConfig, links, pluginDataMap } = data as Omit< | ||
ExportedLayoutV2, | ||
'version' | ||
>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this cast is because the actual data types are part of the dashboard package, but the redux package just marks them as unknown
. We should probably clean that up at some point. Related #730
- Add key to all dashboards - Clean up tests a bit
- I was dumb when naming