Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Save/load plugin data with layout #1866

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Mar 11, 2024

mofojed added 4 commits March 11, 2024 11:04
- Needed to use deephaven.ui from a layout in app mode
- Forces the plugins to reload as well, which gets the pluginDataMap to load correctly for deephaven.ui
@mofojed mofojed requested a review from mattrunyon March 11, 2024 19:25
@mofojed mofojed self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.15%. Comparing base (3ed4f6b) to head (3a22d39).
Report is 4 commits behind head on main.

❗ Current head 3a22d39 differs from pull request most recent head 1488ba7. Consider uploading reports for the commit 1488ba7 to get more accurate results

Files Patch % Lines
packages/code-studio/src/main/AppMainContainer.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
+ Coverage   46.11%   46.15%   +0.03%     
==========================================
  Files         636      636              
  Lines       38070    38071       +1     
  Branches     9627     9627              
==========================================
+ Hits        17556    17570      +14     
+ Misses      20461    20448      -13     
  Partials       53       53              
Flag Coverage Δ
unit 46.15% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/code-studio/src/main/AppMainContainer.tsx Outdated Show resolved Hide resolved
Comment on lines +141 to +144
const { filterSets, layoutConfig, links, pluginDataMap } = data as Omit<
ExportedLayoutV2,
'version'
>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this cast is because the actual data types are part of the dashboard package, but the redux package just marks them as unknown. We should probably clean that up at some point. Related #730

- Add key to all dashboards
- Clean up tests a bit
@mofojed mofojed requested a review from mattrunyon March 13, 2024 14:02
- I was dumb when naming
@mofojed mofojed requested a review from mattrunyon March 15, 2024 15:26
@mofojed mofojed merged commit e64407d into deephaven:main Mar 15, 2024
5 checks passed
@mofojed mofojed deleted the 1861-exported-layout-plugin-data branch March 15, 2024 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported layouts do not contain pluginDataMap
2 participants