Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported layouts do not contain pluginDataMap #1861

Closed
mofojed opened this issue Mar 9, 2024 · 0 comments · Fixed by #1866
Closed

Exported layouts do not contain pluginDataMap #1861

mofojed opened this issue Mar 9, 2024 · 0 comments · Fixed by #1866
Assignees
Labels
bug Something isn't working

Comments

@mofojed
Copy link
Member

mofojed commented Mar 9, 2024

Description

If you open some deephaven.ui widgets and export the layout, then try and import the layout, the deephaven.ui widgets will not load.

Steps to reproduce

  1. Open a deephaven.ui widget
from deephaven import ui

@ui.component
def counter():
    count, set_count = ui.use_state(0)
    return ui.action_button(
        f"You pressed me {count} times", on_press=lambda _: set_count(count + 1)
    )


result = counter()
  1. From the Panels menu, select Export Layout
  2. From the Panels menu, select Reset Layout
  3. From the Panels menu, import the layout you exported in 2

Expected results
4. Same layout should open up

Actual results

  1. deephaven.ui widgets do not hydrate. Inspecting the layout.json shows the pluginDataMap is not saved. See attached.

Additional details and attachments
deephaven-app-layout-2024-03-09-082717.json

Versions

Engine Version: 0.34.0-SNAPSHOT
Web UI Version: 0.68.0
Java Version: 21.0.2
Barrage Version: 0.6.0
Browser Name: Chrome 122
OS Name: macOS 10.15.7

@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Mar 9, 2024
@mofojed mofojed self-assigned this Mar 11, 2024
@mofojed mofojed removed the triage Issue requires triage label Mar 11, 2024
mofojed added a commit that referenced this issue Mar 15, 2024
- Plugin data was not getting saved with the workspace
- Reload the dashboard when a layout is imported by updating the key
- Fixes #1861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant