ci: add TypeScript type check

.github/workflows/typescript-check.yml

@@ -0,0 +1,27 @@
+name: Check TypeScript types
+
+on:
+  push:
+    branches:
+      - main
+      - 'release/**'
+      - 'feature/**'
+  pull_request:
+    branches:
+      - main
+      - 'release/**'
+      - 'feature/**'
+
+jobs:
+  typescript-check:
+    runs-on: ubuntu-latest
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install dependencies
+        run: npm ci
+      - name: Check TypeScript types
+        run: python tools/check_typescript_ci.py
+

plugins/dashboard-object-viewer/src/js/src/DashboardPlugin/DashboardPlugin.tsx

@@ -28,7 +28,10 @@ export function DashboardPlugin({
       widget: VariableDefinition;
     }) => {
       const { id: widgetId, name, type } = widget;
-      if (type === dh.VariableType.TABLE || type === dh.VariableType.FIGURE) {
+      if (
+        type === 'dh.VariableType.TABLE' ||
+        type === 'dh.VariableType.FIGURE'
+      ) {
         // Just ignore table and figure types - only want interesting other types
         return;
       }

plugins/ui/src/js/src/elements/UITable/UITable.tsx

@@ -258,7 +258,9 @@ export function UITable({
     if (alwaysFetchColumnsArray[0] === false) {
       return [];
     }
-    return alwaysFetchColumnsArray.filter(v => typeof v === 'string');
+    return alwaysFetchColumnsArray.filter(
+      v => typeof v === 'string'
+    ) as string[];
   }, [alwaysFetchColumnsArray, modelColumns]);
 
   const mouseHandlers = useMemo(

tools/check_typescript_ci.py

@@ -0,0 +1,38 @@
+from re import fullmatch
+from subprocess import run
+from sys import exit
+
+
+def main():
+    print("Checking TypeScript types...")
+    res = run(
+        ["npx", "tsc", "-p", ".", "--emitDeclarationOnly", "false", "--noEmit"],
+        capture_output=True,
+    )
+
+    if res.returncode == 0:
+        return 0
+
+    errors = []
+    for line in res.stdout.decode("utf-8").splitlines():
+        if len(line) == 0:
+            continue
+        if line[0] == " " and len(errors) > 0:
+            errors[-1] += "\n" + line
+        else:
+            errors.append(line)
+
+    for err in errors:
+        match = fullmatch(r"(.+?)\((\d+),(\d+)\): ([\s\S]+)", err)
+        if match is None:
+            continue
+
+        file, line, col, msg = match.groups()
+        msg = msg.replace("\n", "%0A")
+        print(f"::error file={file},line={line},col={col}::{msg}")
+
+    return res.returncode
+
+
+if __name__ == "__main__":
+    exit(main())