ci: add TypeScript type check #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wusteven815
commented
Nov 5, 2024
wusteven815
commented
- Closes Enforce typescript types in CI builds #618
- Fixes leftover type issues
wusteven815
force-pushed
the
618-typescript-ci
branch
from
73955c7 to
57a9a1a
Compare
|
A failed CI test would look like this: https://github.com/deephaven/deephaven-plugins/actions/runs/11689629674, with an annotation in the files changed section of the PR.
|
mofojed
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Take a look at the build script we have in web-client-ui: https://github.com/deephaven/web-client-ui/blob/ee0af9cf8a64f5c11288672ff09a1a7b305657b3/package.json#L24
We should just be able to run that for type-checking (I think). See if it adds annotations as well.
mofojed
requested changes
Nov 28, 2024
plugins/dashboard-object-viewer/src/js/src/DashboardPlugin/DashboardPlugin.tsx
Outdated
Show resolved
Hide resolved
…hboardPlugin.tsx Co-authored-by: Mike Bender <[email protected]>
mofojed
previously approved these changes
Dec 11, 2024
mofojed
previously approved these changes
Dec 17, 2024
Co-authored-by: Mike Bender <[email protected]>
mofojed
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.