Port DH-12049: Improve and Refactor TestColumnSources and TestDataGeneration #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
clean up
NoDocumentationNeeded
port
ReleaseNotesNeeded
cpwright
reviewed
Jan 6, 2023
...able/src/main/java/io/deephaven/engine/table/impl/sources/UnboxedLongBackedColumnSource.java
Outdated
Show resolved
Hide resolved
| import java.util.function.LongConsumer; | ||
|
|
||
| /** | ||
| * A test column source that ignores additions, only removing values. |
There was a problem hiding this comment.
That's actually wrong. It ignores modifications; throws on removals. Adds when requested.
There was a problem hiding this comment.
You still need to replicate Char, where you fixed it.
There was a problem hiding this comment.
That's embarrassing... Incoming.
...test-utils/src/main/java/io/deephaven/engine/testutil/sources/UnboxedDateTimeTestSource.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableFlattenTest.java
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java
Outdated
Show resolved
Hide resolved
cpwright
approved these changes
Jan 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phew.. I made slightly more changes than in the original commit by fixing up easy no-contest intellij warnings.
Sorry for the huge PR (Charles shares this fault).
Here is the internal jira ticket: DH-11964
Here is the internal commit.
Click here to see the nightlies.