Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LivenessScope for SelectColumnLayer.doApplyUpdate, in order to ensure correct reference counting for parallel update in transform use cases #3210

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Fix LivenessScope for SelectColumnLayer.doApplyUpdate, in order to ensure correct reference counting for parallel update in transform use cases #3210

merged 1 commit into from
Dec 15, 2022

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Dec 14, 2022

Fixes #3209

@rcaudy
Fix LivenessScope for SelectColumnLayer.doApplyUpdate, in order to en…
995ea0b 
…sure reference counting for parallel update in transform use cases
@rcaudy rcaudy added this to the Dec 2022 milestone Dec 14, 2022
@rcaudy rcaudy requested review from lbooker42 and cpwright December 14, 2022 22:25
@rcaudy rcaudy self-assigned this Dec 14, 2022
lbooker42
lbooker42 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested against a failure in my own branch and this resolves it.

@rcaudy rcaudy merged commit 6ced5cd into deephaven:main Dec 15, 2022
@rcaudy rcaudy deleted the rwc-update-liveness-scope branch December 15, 2022 01:53
@rcaudy rcaudy changed the title Fix LivenessScope for SelectColumnLayer.doApplyUpdate, in order to ensure reference counting for parallel update in transform use cases Fix LivenessScope for SelectColumnLayer.doApplyUpdate, in order to ensure correct reference counting for parallel update in transform use cases Dec 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbooker42 lbooker42 lbooker42 approved these changes

@cpwright cpwright Awaiting requested review from cpwright

Assignees

@rcaudy rcaudy

Labels
bug Something isn't working NoDocumentationNeeded partitioned_tables query engine ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
Dec 2022
Development

Successfully merging this pull request may close these issues.

Select/Update bug in Liveness for transform use-cases
2 participants
@rcaudy @lbooker42