Fix LivenessScope for SelectColumnLayer.doApplyUpdate, in order to en…

…sure correct reference counting for parallel update in transform use cases (#3210)
deephaven · Dec 15, 2022 · 6ced5cd · 6ced5cd
1 parent 67c63f8
commit 6ced5cd
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/...able/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectColumnLayer.java b/...able/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectColumnLayer.java
@@ -11,6 +11,7 @@
 import io.deephaven.engine.context.ExecutionContext;
 import io.deephaven.engine.liveness.LivenessNode;
 import io.deephaven.engine.liveness.LivenessReferent;
+import io.deephaven.engine.liveness.LivenessScopeStack;
 import io.deephaven.engine.rowset.*;
 import io.deephaven.engine.table.*;
 import io.deephaven.engine.table.impl.QueryTable;
@@ -291,13 +292,16 @@ private Boolean doApplyUpdate(final TableUpdate upstream, final UpdateHelper hel
         final boolean isBackingChunkExposed =
                 ChunkedBackingStoreExposedWritableSource.exposesChunkedBackingStore(writableSource);
 
-        try (final ChunkSink.FillFromContext destContext =
-                needDestContext ? writableSource.makeFillFromContext(destContextSize) : null;
-                final ChunkSource.GetContext chunkSourceContext =
-                        needGetContext ? chunkSource.makeGetContext(chunkSourceContextSize) : null;
-                final ChunkSource.FillContext chunkSourceFillContext =
-                        needGetContext && isBackingChunkExposed ? chunkSource.makeFillContext(chunkSourceContextSize)
-                                : null) {
+        try (final SafeCloseable ignored = LivenessScopeStack.open();
+                final ChunkSink.FillFromContext destContext = needDestContext
+                        ? writableSource.makeFillFromContext(destContextSize)
+                        : null;
+                final ChunkSource.GetContext chunkSourceContext = needGetContext
+                        ? chunkSource.makeGetContext(chunkSourceContextSize)
+                        : null;
+                final ChunkSource.FillContext chunkSourceFillContext = needGetContext && isBackingChunkExposed
+                        ? chunkSource.makeFillContext(chunkSourceContextSize)
+                        : null) {
 
             // apply shifts!
             if (!isRedirected && preMoveKeys.isNonempty()) {