-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetty update #3
Jetty update #3
Changes from 5 commits
9d0c39e
8f24408
86079c4
e9c2ffe
230512f
a2fb62e
23b1f7b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import matplotlib.pyplot as plt | ||
|
||
plt.figure() | ||
x = [0, 2, 4, 6] | ||
y = [1, 3, 4, 8] | ||
plt.plot(x, y) | ||
plt.xlabel("x values") | ||
plt.ylabel("y values") | ||
plt.title("plotted x and y values") | ||
plt.legend(["line 1"]) | ||
|
||
m_figure = plt.gcf() |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,9 @@ | ||
version: "3.4" | ||
version: "3" | ||
|
||
services: | ||
server: | ||
build: ./server | ||
expose: | ||
- '8080' | ||
volumes: | ||
- ./data:/data | ||
- api-cache:/cache | ||
environment: | ||
- JAVA_TOOL_OPTIONS=-Xmx4g -Ddeephaven.console.type=python | ||
|
||
web: | ||
build: ./web | ||
expose: | ||
- '80' | ||
volumes: | ||
- ./data:/data | ||
- web-tmp:/tmp | ||
|
||
grpc-proxy: | ||
image: ghcr.io/deephaven/grpc-proxy:${VERSION:-latest} | ||
environment: | ||
- BACKEND_ADDR=server:8080 | ||
depends_on: | ||
- server | ||
expose: | ||
- '8080' | ||
|
||
envoy: | ||
image: ghcr.io/deephaven/envoy:${VERSION:-latest} | ||
depends_on: | ||
- web | ||
- grpc-proxy | ||
- server | ||
ports: | ||
- "${DEEPHAVEN_PORT:-10000}:10000" | ||
|
||
examples: | ||
image: ghcr.io/deephaven/examples:latest | ||
volumes: | ||
- ./data:/data | ||
command: initialize | ||
|
||
volumes: | ||
web-tmp: | ||
api-cache: | ||
- "10000:10000" |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,3 +1,9 @@ | ||||||
FROM ghcr.io/deephaven/server:${VERSION:-latest} | ||||||
# pip install any of the plugins required on the server | ||||||
RUN pip install deephaven-plugin-matplotlib | ||||||
# syntax=docker/dockerfile:1.4 | ||||||
|
||||||
FROM ghcr.io/deephaven/web-plugin-packager:latest as build | ||||||
RUN ./pack-plugins.sh @deephaven/js-plugin-matplotlib | ||||||
|
||||||
FROM ghcr.io/deephaven/server:latest | ||||||
RUN pip install --no-cache-dir deephaven-plugin-matplotlib | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Matplotlib should be installed in the Dockerfile as well There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mofojed doesn't There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That said, it's not bad to be explicit here since we do rely directly on matplotlib. |
||||||
COPY --link --from=build js-plugins/ /opt/deephaven/config/js-plugins/ | ||||||
COPY --link deephaven.prop /opt/deephaven/config/deephaven.prop |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
includefiles=dh-defaults.prop | ||
|
||
deephaven.console.type=python | ||
|
||
deephaven.jsPlugins.resourceBase=/opt/deephaven/config/js-plugins |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a line at the bottom of the README that we should remove since we removed the examples: