-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetty update #3
Jetty update #3
Conversation
https://github.com/devinrsmith/deephaven-extra-images is relevant too - it may be the template we provide for building your own images off of Deephaven. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like it's working for me, server says it's started up but getting a socket error when navigating to http://localhost:10000/ide/
docker-compose pull | ||
docker-compose up --build -d | ||
docker compose pull | ||
docker compose up --build -d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a line at the bottom of the README that we should remove since we removed the examples:
The 3D examples in this readme are from Rashida Nasrin Sucky the data is available from kaggle
server/Dockerfile
Outdated
RUN ./pack-plugins.sh @deephaven/js-plugin-matplotlib | ||
|
||
FROM ghcr.io/deephaven/server:latest | ||
RUN pip install --no-cache-dir deephaven-plugin-matplotlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN pip install --no-cache-dir deephaven-plugin-matplotlib | |
RUN pip install --no-cache-dir deephaven-plugin-matplotlib matplotlib |
Matplotlib should be installed in the Dockerfile as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mofojed doesn't deephaven-plugin-matplotlib
depend on matplotlib
? We shouldn't need to re specify dependency IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, it's not bad to be explicit here since we do rely directly on matplotlib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add matplotlib to the pip install in the Dockerfile. The rest looks good to merge
I think we'll want to simplify this not to rely on another data image.
We'll also need to wait for the official release, but this is the construction we can use for plugins.