Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty update #3

Merged
merged 7 commits into from
Nov 16, 2022
Merged

Conversation

devinrsmith
Copy link
Member

I think we'll want to simplify this not to rely on another data image.

We'll also need to wait for the official release, but this is the construction we can use for plugins.

@devinrsmith
Copy link
Member Author

https://github.com/devinrsmith/deephaven-extra-images is relevant too - it may be the template we provide for building your own images off of Deephaven.

@devinrsmith devinrsmith requested a review from mofojed November 14, 2022 22:37
Copy link
Contributor

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like it's working for me, server says it's started up but getting a socket error when navigating to http://localhost:10000/ide/

docker-compose pull
docker-compose up --build -d
docker compose pull
docker compose up --build -d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a line at the bottom of the README that we should remove since we removed the examples:

The 3D examples in this readme are from Rashida Nasrin Sucky the data is available from kaggle

@devinrsmith devinrsmith requested a review from mofojed November 16, 2022 20:05
RUN ./pack-plugins.sh @deephaven/js-plugin-matplotlib

FROM ghcr.io/deephaven/server:latest
RUN pip install --no-cache-dir deephaven-plugin-matplotlib
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN pip install --no-cache-dir deephaven-plugin-matplotlib
RUN pip install --no-cache-dir deephaven-plugin-matplotlib matplotlib

Matplotlib should be installed in the Dockerfile as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mofojed doesn't deephaven-plugin-matplotlib depend on matplotlib? We shouldn't need to re specify dependency IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, it's not bad to be explicit here since we do rely directly on matplotlib.

Copy link
Collaborator

@jjbrosnan jjbrosnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add matplotlib to the pip install in the Dockerfile. The rest looks good to merge

@devinrsmith devinrsmith merged commit 63c7160 into deephaven-examples:main Nov 16, 2022
@devinrsmith devinrsmith deleted the jetty-update branch November 16, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants