feat: auction detail #627
feat: auction detail #627
Conversation
nicosantangelo
force-pushed
the
feat/auction-detail
branch
from
024df8f to
3206dcb
Compare
nicosantangelo
changed the title
nicosantangelo
changed the title
nicosantangelo
force-pushed
the
feat/auction-detail
branch
from
3206dcb to
c069055
Compare
nicosantangelo
force-pushed
the
feat/auction-detail
branch
from
353e71c to
ba4b6c2
Compare
There was a problem hiding this comment.
Great Nico!
General comments:
-
It is weird for me to see the parcels in a different order from the one I choose. I would remove the order or if we want it, I will also add it to the parcel selection for creating an Estate. cc: @abarmat @cazala
-
I think we should have a title for the parcels selected and also be consistent with the margin between rows:
shared/parcel.js
Outdated
| @@ -10,6 +10,16 @@ export function isParcel(asset) { | |||
| ) | |||
| } | |||
|
|
|||
| export function getParcelSorter() { | |||
There was a problem hiding this comment.
Just a thought: we could name it as parcelSortAlgorithm or just sortParcel
There was a problem hiding this comment.
"sortParcel" would be the return value of this function, since that's the actual function that does the sorting. I think it's fine returning it as a lambda tho, as it is doing now.
src/Translation/locales/es.json
Outdated
| @@ -104,6 +104,7 @@ | |||
| "your_parcel": "Tu parcela" | |||
| }, | |||
| "auction_page": { | |||
| "bid": "Oferta", | |||
There was a problem hiding this comment.
Maybe Ofertar is better
| <Grid.Column mobile={16} computer={10}> | ||
| <div className="information-blocks"> | ||
| <div className="information-block"> | ||
| <p className="subtitle">GAS PRICE</p> |
There was a problem hiding this comment.
Is it worth to have this on translations?
| <Header size="large">300wei</Header> | ||
| </div> | ||
| <div className="information-block"> | ||
| <p className="subtitle">PARCEL PRICE</p> |
There was a problem hiding this comment.
Maybe LAND PRICE and also I would add it to the translations
| <Header size="large">{this.parcelPrice}</Header> | ||
| </div> | ||
| <div className="information-block"> | ||
| <p className="subtitle">PARCELS</p> |
There was a problem hiding this comment.
Same about translations
| </Header> | ||
| </div> | ||
| <div className="information-block"> | ||
| <p className="subtitle">TOTAL PRICE</p> |
There was a problem hiding this comment.
Same about translations
|
Updated! |
|
Updated without sort |
Adds the detail page for the auction, meaning what you see when you click the navbar auction. You can click unowned parcels and see how the UI reacts, all the data is mocked, so
Biddoesn't work.Closes #606 #610
Continues #626