refactor: coordinates. Auction PR: 2nd #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eordano
reviewed
Oct 30, 2018
shared/coordinate.spec.js
Outdated
| describe('.validateCoordinate', function() { | ||
| it('should throw if the supplied coordinates are invalid', function() { | ||
| expect(() => coordinates.validateCoordinate('a,b')).to.throw( | ||
| 'The coordinate "a,b" are not valid' |
nicosantangelo
force-pushed
the
refactor/coordinates
branch
from
6716c42 to
5b32de7
Compare
Merged
nicosantangelo
force-pushed
the
refactor/coordinates
branch
3 times, most recently
from
d08f90e to
5a867d9
Compare
nicosantangelo
changed the title
nicosantangelo
force-pushed
the
refactor/coordinates
branch
from
5a867d9 to
a0bd21a
Compare
nicosantangelo
force-pushed
the
refactor/coordinates
branch
from
81f0abf to
1766c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty big refactor removing duplications over the coordinates management. It doesn't add any new features
It continues #625 , will rebase after that.