Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BoundingBox #905

Merged
merged 1 commit into from
Feb 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@ export class EcsEntity extends BABYLON.TransformNode {
const meshesBoundingBox = this.getMeshesBoundingBox()

this.boundingInfoMesh = new BABYLON.Mesh(`BoundingMesh-${this.id}`)
this.boundingInfoMesh.parent = this
this.boundingInfoMesh.position = this.absolutePosition
this.boundingInfoMesh.rotationQuaternion = this.absoluteRotationQuaternion
this.boundingInfoMesh.scaling = this.absoluteScaling

this.boundingInfoMesh.setBoundingInfo(
new BABYLON.BoundingInfo(meshesBoundingBox.minimum, meshesBoundingBox.maximum, this.getWorldMatrix())
Expand All @@ -186,6 +188,15 @@ export class EcsEntity extends BABYLON.TransformNode {
this.onAfterWorldMatrixUpdateObservable.addOnce((eventData) => {
void validateEntityIsOutsideLayout(eventData as EcsEntity)
})

// Updates the boundingInfoMesh position, rotation and scaling
this.onAfterWorldMatrixUpdateObservable.add((eventData) => {
if (this.boundingInfoMesh) {
this.boundingInfoMesh.position = eventData.absolutePosition
this.boundingInfoMesh.rotationQuaternion = eventData.absoluteRotationQuaternion
this.boundingInfoMesh.scaling = eventData.absoluteScaling
}
})
}
}
}
Expand Down
Loading