fix: BoundingBox #905
Merged
fix: BoundingBox #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
fe17f47
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2517879f.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://fix-bouding-box.js-sdk-toolchain.pages.dev |
cazala
approved these changes
Feb 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 66.78% 66.81% +0.02%
==========================================
Files 524 524
Lines 16531 16542 +11
Branches 2109 2111 +2
==========================================
+ Hits 11041 11052 +11
Misses 5155 5155
Partials 335 335 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bounding box when loading the gltf twice during the assets and the GLTFComponent initialization, removing the parent link between the bounding box mesh and the entity and managing the bounding box translation separately.