Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Scene parcels shortcut #767

Merged
merged 1 commit into from
Oct 6, 2023
Merged

add: Scene parcels shortcut #767

merged 1 commit into from
Oct 6, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Oct 4, 2023

closes decentraland/sdk#887

🤖 Generated by Copilot at 267ff79

This pull request adds a new feature and improves the UI of the scene inspector component in the @dcl/inspector package. It allows users to switch between manual and automatic layout of the parcels input for a scene. It also adds an icon, removes a label, and updates the utility functions and tests for the component.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc987aa
Status: ✅  Deploy successful!
Preview URL: https://90c22c11.js-sdk-toolchain.pages.dev
Branch Preview URL: https://add-scene-parcels-shortcut.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/scene-parcels-shortcut/dcl-sdk-7.3.19-6435087888.commit-d1aa7ee.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/scene-parcels-shortcut/dcl-sdk-commands-7.3.19-6435087888.commit-d1aa7ee.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/scene-parcels-shortcut/@dcl/inspector/dcl-inspector-7.3.19-6435087888.commit-d1aa7ee.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/add/scene-parcels-shortcut-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=add/scene-parcels-shortcut

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5f33809) 71.47% compared to head (6e68b87) 71.95%.
Report is 2 commits behind head on main.

❗ Current head 6e68b87 differs from pull request most recent head fc987aa. Consider uploading reports for the commit fc987aa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   71.47%   71.95%   +0.47%     
==========================================
  Files         382      382              
  Lines       12680    12718      +38     
  Branches     1703     1722      +19     
==========================================
+ Hits         9063     9151      +88     
+ Misses       3416     3367      -49     
+ Partials      201      200       -1     
Files Coverage Δ
...components/EntityInspector/SceneInspector/utils.ts 100.00% <100.00%> (+100.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicoecheza nicoecheza force-pushed the add/scene-parcels-shortcut branch 3 times, most recently from b807388 to 6e68b87 Compare October 5, 2023 13:48
@nicoecheza nicoecheza enabled auto-merge (squash) October 5, 2023 14:17
@nicoecheza nicoecheza force-pushed the add/scene-parcels-shortcut branch from 6e68b87 to fc987aa Compare October 6, 2023 18:16
@nicoecheza nicoecheza merged commit 9b97e80 into main Oct 6, 2023
@nicoecheza nicoecheza deleted the add/scene-parcels-shortcut branch October 6, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shortcut to list parcels for large scenes
2 participants