This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
fix: AvatarModel's Equals method #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbosio
requested review from
pravusjif and
BrianAmadori
and removed request for
a team
|
This branch can be previewed at https://explorer.decentraland.zone/branch/fix/avatarmodel-equals-func/index.html |
pravusjif
approved these changes
Oct 15, 2020
BrianAmadori
approved these changes
Oct 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AvatarModel's
Equalsmethod was not taking into account changes on avatar expressionsWhat?
adds
expressionTriggerIdandexpressionTriggerTimestampto theEqualscomparisonWhy?
for the wearables editor, changing AvatarShape expression didn't trigger the animation unless something else (like wearables) changed