This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
chore: added DCL NSubstitute package + PrivateChat Implementation #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch can be previewed at https://explorer.decentraland.zone/branch/chore/1362_nsubstitute/index.html |
sandrade-dcl
approved these changes
Oct 6, 2020
| @@ -11,6 +11,14 @@ public enum Type | |||
| SYSTEM | |||
| } | |||
|
|
|||
| public ChatMessage() { } | |||
There was a problem hiding this comment.
Why is it necessary to create an empty constructor? Is it only for standard conventions? or is it being used in some place?
There was a problem hiding this comment.
So we can use object initializers like new ChatMessage { messageType = "type" } ;
pravusjif
approved these changes
Oct 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding NSubstitue and converting one of our tests as an example.
The NSubstitute fork we are using is located here https://github.com/decentraland/Unity3D-NSubstitute. You can take a look at the
cdd11bb74398afae73e71b6fe01114f597a6ce08commit for a more generic example of use.Said generic example can also be checked within Unity:
