fix: camera jitter in moving platforms #1327
Conversation
|
This branch can be previewed at https://explorer.decentraland.zone/branch/fix/CameraJitterInMovingPlatforms/index.html |
| entity.components.Add(classId, null); | ||
|
|
||
| lerpController = entity.gameObject.AddComponent<TransformLerpController>(); |
There was a problem hiding this comment.
Caution: enabling lerping for all the transforms will cause a lot of unwanted behaviour. We should at least enable this only on transforms that we are landed to. Remember the air balloon is animation based, this could break other system-based movements.
There was a problem hiding this comment.
Right now the TransformLerpController is doing nothing different than the behaviour we already had, because we are not using its lerpingSpeed.
I just left that component there so that when we introduce transform lerping we could just start using that speed property (be it by calculating the speed before or reading it from a property of the SDK component model), and we could also add a different lerping speed for rotation and scaling.
There was a problem hiding this comment.
I removed the TransformLerpController usage
WHY?
right now the third person camera tries to accomodate its vertical position always and that gets clunky when the character is on a vertical moving platform, leading to a bad UX
WHAT?
We are disabling the camera positioning auto-damping when the chara is on a moving platform and resetting those values when he gets out of the moving platform
TESTING
You can test this in Genesis Plaza's air balloon moving platform, specially when moving up/down and having the camera pointing down to the character (instead of having the camera at the character-level or below), by comparing the camera jittering/stuttering in prod and in this branch:
prod: http://play.decentraland.org/
this branch: https://explorer.decentraland.zone/branch/fix/CameraJitterInMovingPlatforms/index.html?ENV=org