Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/v0.4.4 #2682

Merged
merged 17 commits into from
Jan 21, 2025
Merged

Hotfix/v0.4.4 #2682

merged 17 commits into from
Jan 21, 2025

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Jan 21, 2025

Hotfix to Fix NFT Voting, which is currently showstopping VANTA DAO!!!

Includes PRs:

Testing:

adamgall and others added 16 commits January 21, 2025 13:27
…user reference handling

- Modified `getCanVote` function to accept `remainingTokenIdsLength` as a parameter for better clarity and efficiency.
- Updated user reference management to use a hex representation of the user's address combined with the length of remaining token IDs.
- Ensured that the voting eligibility logic remains intact while enhancing readability and maintainability.
This reverts commit 56ad071, reversing
changes made to d2d4d4a.
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025

Deploying decent-interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e9dcd7
Status: ✅  Deploy successful!
Preview URL: https://c7777269.decent-interface.pages.dev
Branch Preview URL: https://hotfix-v0-4-4.decent-interface.pages.dev

View logs

Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks exactly what I was expecting to see in this hotfix - haven't re-tested since I already casted vote on Contango but do not expect any difference

@adamgall
Copy link
Member Author

I'm merging this.

@adamgall adamgall merged commit 1962fb3 into main Jan 21, 2025
4 checks passed
@adamgall adamgall deleted the hotfix/v0.4.4 branch January 21, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants